Skip to content

[GEP-25] Enable Shoot cloudProfile reference as complement to cloudProfileName #853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2024
Merged

[GEP-25] Enable Shoot cloudProfile reference as complement to cloudProfileName #853

merged 1 commit into from
Oct 4, 2024

Conversation

LucaBernstein
Copy link
Member

@LucaBernstein LucaBernstein commented Sep 30, 2024 •
edited
Loading

Switch from CloudProfile to CloudProfileSpec as a generic foundation for CloudProfile and NamespacedCloudProfile.

Improve log message for possibly artificially crafted CloudProfile from NamespacedCloudProfile in Cluster resource.

How to categorize this PR?

/area open-source
/area usability
/kind api-change
/kind enhancement
/platform gcp

What this PR does / why we need it:
Make the Azure provider extension aware of the CloudProfile field and the option to provide NamespacedCloudProfile references in the shoot.Spec.CloudProfile.
See also GEP-25 and this PR.

Which issue(s) this PR fixes:
Related to gardener/gardener#9504

Special notes for your reviewer:

Release note:

Enable support for the field `shoot.Spec.CloudProfile` alongside `shoot.Spec.CloudProfileName` and enable the future use of `NamespacedCloudProfile`.

@LucaBernstein
Add NamespacedCloudProfile support to Shoot validation.
0156e94 
Switch from CloudProfile to CloudProfileSpec as a generic foundation for CloudProfile and NamespacedCloudProfile.

Improve log message for possibly artificially crafted CloudProfile from NamespacedCloudProfile in Cluster resource.
@LucaBernstein LucaBernstein requested review from a team as code owners September 30, 2024 12:39
@gardener-robot gardener-robot added needs/review Needs review area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension platform/gcp Google cloud platform/infrastructure labels Sep 30, 2024
@LucaBernstein LucaBernstein mentioned this pull request Sep 30, 2024
Open
45 tasks
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 30, 2024
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Sep 30, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 30, 2024
@hebelsan
Copy link
Contributor

hebelsan commented Oct 1, 2024

lgtm

kon-angelo
kon-angelo approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@kon-angelo kon-angelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kon-angelo kon-angelo merged commit d79a252 into gardener:master Oct 4, 2024
18 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 4, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 4, 2024
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 4, 2024
@LucaBernstein LucaBernstein deleted the gep-25-enable-shoot-spec-cloudprofile branch November 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kon-angelo kon-angelo kon-angelo approved these changes

Assignees
No one assigned
Labels
area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/usability Usability related kind/api-change API change with impact on API users kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/gcp Google cloud platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LucaBernstein @hebelsan @kon-angelo @gardener-robot-ci-2 @gardener-robot-ci-3 @gardener-robot