Skip to content

Make extension ports configurable via helm values #1090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

Make extension ports configurable via helm values #1090

merged 2 commits into from
Feb 18, 2025

Conversation

ScheererJ
Copy link
Member

How to categorize this PR?

/area networking
/kind enhancement
/platform azure

What this PR does / why we need it:

Make extension ports configurable via helm values.

In certain scenarios, e.g. in the autonomous cluster use case, multiple extensions may run side-by-side in the host network. In this case, they cannot use the same ports. Therefore, it should be possible to inject the usable ports from outside via helm values.

Which issue(s) this PR fixes:
Part of gardener/gardener#2906

Special notes for your reviewer:

Release note:

The ports used by the extension can now be specified via helm values.

@ScheererJ ScheererJ requested review from a team as code owners February 17, 2025 11:57
@gardener-robot gardener-robot added needs/review Needs review area/networking Networking related kind/enhancement Enhancement, improvement, extension platform/azure Microsoft Azure platform/infrastructure labels Feb 17, 2025
@ScheererJ ScheererJ mentioned this pull request Feb 17, 2025
Open
@gardener-robot gardener-robot added the size/s Size of pull request is small (see gardener-robot robot/bots/size.py) label Feb 17, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2025
AndreasBurger
AndreasBurger previously approved these changes Feb 17, 2025
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ScheererJ
Copy link
Member Author

/hold

@gardener-robot gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 17, 2025
@ScheererJ ScheererJ force-pushed the enhancement/make-extension-port branch from e267391 to 8534375 Compare February 17, 2025 17:53
@gardener-robot gardener-robot added the needs/rebase Needs git rebase label Feb 17, 2025
@gardener-robot
Copy link

@ScheererJ You need rebase this pull request with latest master branch. Please check.

@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2025
@ScheererJ
Copy link
Member Author

/unhold

@gardener-robot gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Feb 17, 2025
@ScheererJ ScheererJ force-pushed the enhancement/make-extension-port branch from 8534375 to c1d43da Compare February 17, 2025 18:02
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Feb 17, 2025
@ScheererJ ScheererJ force-pushed the enhancement/make-extension-port branch from c1d43da to 2aa8453 Compare February 17, 2025 18:04
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 17, 2025
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Feb 17, 2025
AndreasBurger
AndreasBurger approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@AndreasBurger AndreasBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kon-angelo kon-angelo merged commit c213f5b into gardener:master Feb 18, 2025
10 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreasBurger AndreasBurger AndreasBurger approved these changes

Assignees
No one assigned
Labels
area/networking Networking related kind/enhancement Enhancement, improvement, extension needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/rebase Needs git rebase needs/review Needs review platform/azure Microsoft Azure platform/infrastructure size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ScheererJ @gardener-robot @AndreasBurger @gardener-robot-ci-2 @gardener-robot-ci-3 @kon-angelo