Skip to content

Conversation

LucaBernstein
Copy link
Member

@LucaBernstein LucaBernstein commented Dec 13, 2024

How to categorize this PR?

/area usability
/kind bug
/platform aws

What this PR does / why we need it:
With gardener/gardener#10937 the mutator was not able to update the status anymore. Now, the subresource handler is properly used.

Which issue(s) this PR fixes:
Related to gardener/gardener#9504.

Special notes for your reviewer:

Release note:

Fix the `NamespacedCloudProfile` status mutation.

@LucaBernstein LucaBernstein requested review from a team as code owners December 13, 2024 13:21
@gardener-robot gardener-robot added needs/review Needs review area/usability Usability related kind/bug Bug platform/aws Amazon web services platform/infrastructure size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) labels Dec 13, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Dec 13, 2024
@LucaBernstein
Copy link
Member Author

/cc @timuthy @dguendisch

Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Dec 16, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Dec 16, 2024
@hebelsan hebelsan merged commit 318ec65 into gardener:master Dec 16, 2024
19 checks passed
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Dec 16, 2024
@LucaBernstein LucaBernstein deleted the fix-nscpfl-status-patching branch December 16, 2024 08:28
@LucaBernstein LucaBernstein restored the fix-nscpfl-status-patching branch December 16, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/usability Usability related kind/bug Bug needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) platform/aws Amazon web services platform/infrastructure reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xs Size of pull request is tiny (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants