Introduce gosec for Static Application Security Testing (SAST)
#9959
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G101: Look for hard coded credentials
G404: Insecure random number source (rand)
G109: Potential Integer overflow made by strconv.Atoi result conversion to int16/32
G402: Look for bad TLS connection settings
G301: Poor file permissions used when creating a directory G306: Poor file permissions used when writing to a new file
G304: File path provided as taint input
G204: Audit use of command execution
G401: Detect the usage of DES, RC4, MD5 or SHA1 G505: Import blocklist: crypto/sha1
LucaBernstein
requested changes
Jun 12, 2024
|
/assign |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LucaBernstein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
|
/lgtm cancel If there are multiple reviewers, one can add |
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-gardenlinux
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-gardenlinux
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-suse-chost
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-ubuntu
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-gardenlinux
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-suse-chost
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-os-coreos
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-runtime-gvisor
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to gardener/gardener-extension-os-suse-chost
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to gardener/gardener-extension-os-gardenlinux
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to gardener/gardener-extension-os-coreos
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to gardener/gardener-extension-os-ubuntu
that referenced
this pull request
Nov 18, 2024
MrBatschner
added a commit
to MrBatschner/gardener-extension-runtime-gvisor
that referenced
this pull request
Nov 19, 2024
MrBatschner
added a commit
to gardener/gardener-extension-runtime-gvisor
that referenced
this pull request
Nov 21, 2024
* enable gosec for static code analysis as enabled by gardener/gardener#9959 * address G304 finding
This was referenced Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area compliance security
/kind enhancement
What this PR does / why we need it:
This PR introduces
gosecfor Static Application Security Testing at Gardener and should replace other code scanners.It uses the default ruleset of
gosecwith two exceptions../hackfolder is excluded, becausegosecdoes not support nested go modules (like logcheck) and there is no productive code in this folder anyway.All findings based on these settings have been mitigated in this PR.
There are two new
maketargets.make sastis supposed to be called in unit tests. It logs all finding to console and fails in case of errors.make sast-reportcan be used in build pipelines. It fails on errors too. Additionally, it creates a report in sarif format to./gosec-report.sariffile. This report also tracks suppressed findings.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
cc @ccwienk @ThormaehlenFred @dkistner
Release note: