Introduce core.gardener.cloud/v1.ControllerDeployment API
#9771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
|
/retest |
|
/assign |
rfranzke
reviewed
May 21, 2024
|
Thanks, done. PTAL :) |
API reference docs cannot be generated for empty API groups, so the generation will be added later once the first resource has been added.
This is a prerequisite for implementing conversion from the `v1beta1` API to the new structure in the internal and `v1` API version.
…ControllerDeployment`
…ntrollerDeployment`
46171a0 to
1319a4b
Compare
Done :) |
|
I think we are good to go. Let's get this in, especially since it's a prerequisite for other features (cc @maboehm @kon-angelo @vknabel). Thanks for your efforts 🎉 /lgtm |
|
LGTM label has been added. Git tree hash: 0bf337020733a38ed7a143214c40a5da1af866b8
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 31, 2024
(from gardener#9771, released with `v1.96.0`)
Merged
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 31, 2024
(from gardener#9771, released with `v1.96.0`)
dimitar-kostadinov
added a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
Jun 3, 2024
…ardener#9771. - Exclude local-setup from the REUSE compliance check. - Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.
gardener-prow bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Remove deprecated fields from `OperatingSystemConfig` (from #9477, released with `v1.92.0`) * Remove cleanup of old `kube-apiserver` `Ingress` resource (from #9300, released with `v1.91.0`) * Remove Istio zone migration code (from #9304 and #9457, released with `v1.91.0` and `v1.92.0`) * Increase removal period of `<name>.ca-cluster` `Secret` To give users more time to adapt * Remove PVC migration for `garden` Prometheus (from #9543, released with `v1.93.0`) * Remove PVC migration for `longterm` Prometheus (from #9606, released with `v1.94.0`) * Drop migration code in `skaffold.yaml` for `core.gardener.cloud/v1` API (from #9771, released with `v1.96.0`) * Remove migration code for e2e upgrade tests after `provider-local` VPN fix (from #9752, released with `v1.96.0`) * Remove cleanup of old `vali` `VerticalPodAutoscaler`s (from #9681, released with `v1.94.0`) * Remove cleanuop code after making `Secret`s of `ManagedResource`s immutable (from #8116, released with `v1.77.0`) * Remove cleanup code of resources of legacy `cloud-config-downloader` (from #8847, released with `v1.85.0`) * Revert "Remove Istio zone migration code" This reverts commit 8850346. * Increase removal period of Istio zone migration code
dimitar-kostadinov
added a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
Jun 4, 2024
…dener#9771. Exclude local-setup from the REUSE compliance check. Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.
dimitar-kostadinov
added a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
Jun 4, 2024
…dener#9771. Exclude local-setup from the REUSE compliance check. Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.
gardener-prow bot
pushed a commit
to gardener/gardener-extension-registry-cache
that referenced
this pull request
Jun 5, 2024
* Bump github.com/gardener/gardener from 1.95.2 to 1.96.1 Bumps [github.com/gardener/gardener](https://github.com/gardener/gardener) from 1.95.2 to 1.96.1. - [Release notes](https://github.com/gardener/gardener/releases) - [Commits](gardener/gardener@v1.95.2...v1.96.1) --- updated-dependencies: - dependency-name: github.com/gardener/gardener dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * [GEP-19] Adapt monitoring configuration * Use `core.gardener.cloud/v1.ControllerDeployment` - ref: gardener/gardener#9771. Exclude local-setup from the REUSE compliance check. Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766. * Fix e2e tests Ref: gardener/gardener#9752 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Dimitar Kostadinov <dimitar.kostadinov@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity usability
/kind enhancement
What this PR does / why we need it:
This PR introduces the new
core.gardener.cloud/v1API version including theControllerDeploymentresource.The v1 API drops support for custom types and replaces
providerConfigwith a proper API structure for helm-basedControllerDeployments.gardener-apiserver stores the
ControllerDeploymentresource in the v1 version but can perform lossless conversion from and tov1beta1.The new API version is introduced to support further developments augmenting helm-based
ControllerDeployments(e.g., OCI registry support instead of raw charts).As we move away from the
providerConfigapproach, we need a new API version.All other
core.gardener.cloudresources are still only available inv1beta1. This PR lays the foundation for graduating other resources tov1later on as well.Which issue(s) this PR fixes:
Part of #9773
Special notes for your reviewer:
Co-Authored-By: @maboehm
Release note:
A new `core.gardener.cloud/v1` API version is introduced which only includes the `ControllerDeployment` resource for now. The new version of the `ControllerDeployment` drops the `type` and `providerConfig` fields in favor of a well-structured section for helm-based `ControllerDeployments`.