Drop HVPA for KCM and use VPA instead #9698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/assign |
|
/invite @voelzmo |
|
/test pull-gardener-integration |
|
/retest |
rfranzke
requested changes
May 7, 2024
pkg/component/kubernetes/controllermanager/controllermanager.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager.go
Outdated
Show resolved
Hide resolved
|
/assign |
f777398 to
168962e
Compare
voelzmo
suggested changes
May 8, 2024
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
plkokanov
requested changes
May 8, 2024
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
pkg/component/kubernetes/controllermanager/controllermanager_test.go
Outdated
Show resolved
Hide resolved
|
LGTM label has been added. Git tree hash: 183ec2daedb66608a5e5a0112fdff49ae81629ae
|
|
Apart from @plkokanov 's comments, I don't anything else to add: lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 22aa260755a1c64f8249ed1a54c1352903290f11
|
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Jul 29, 2024
(part of gardener#9698, released with `v1.95.0`)
Merged
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Jul 29, 2024
(part of gardener#9698, released with `v1.95.0`)
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
Jul 31, 2024
(part of gardener#9698, released with `v1.95.0`)
gardener-prow bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
* Drop deletion of deprecated `allow-to-shoot-networks` `NetworkPolicy` (part of #9752, released with `v1.96.0`) * Drop fetching extension observability configs with deprecated/legacy method (part of #9695, released with `v1.95.0`) * Drop Prometheus/Alertmanager migration coding (part of #9695, released with `v1.95.0`) * Drop deprecated `.spec.pools[].userData` from `extensions.gardener.cloud/v1alpha1.Worker` API (part of #9722, released with `v1.95.0`) * Drop OSC hash migration `Secret` creation (part of #9846, released with `v1.97.0`) * Drop OSC hash assertion from upgrade tests (part of #9865, released with `v1.98.0`) * Drop removal code of `HVPA` resources (part of #9698, released with `v1.95.0`) * Address PR review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
As part of the topic to remove usages of HVPA where possible, this PR drops HVPA in favour of VPA for the kube-controller-manager deployment.
Special notes for your reviewer:
Previously HVPA specified a scaleDown policy, which could be used to stabilise by suppressing evictions driven by scale down.
Release note: