[GEP-19] Integrate Prometheus and blackbox-exporter deployments into Garden controller
#9543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
46 tasks
Garden controllerblackbox-exporter deployment into Garden controller
blackbox-exporter deployment into Garden controllerblackbox-exporter deployments into Garden controller
|
/assign |
rickardsjp
suggested changes
Apr 5, 2024
pkg/component/observability/monitoring/prometheus/garden/scrapeconfigs.go
Outdated
Show resolved
Hide resolved
bc8b66f to
94711d8
Compare
ScheererJ
reviewed
Apr 9, 2024
pkg/component/observability/monitoring/prometheus/garden/assets/prometheusrules/shoot.yaml
Outdated
Show resolved
Hide resolved
pkg/component/observability/monitoring/blackboxexporter/blackboxexporter.go
Outdated
Show resolved
Hide resolved
pkg/component/observability/monitoring/blackboxexporter/garden/config.go
Outdated
Show resolved
Hide resolved
94711d8 to
93a4676
Compare
93a4676 to
46453f1
Compare
46453f1 to
fd44adf
Compare
fd44adf to
c8e2938
Compare
Otherwise, it will remain in the system even after `Garden` got deleted, causing issues with future `Garden` creations, see for example: https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/9543/pull-gardener-e2e-kind-operator/1776264086145732608
c8e2938 to
6fc17c9
Compare
6fc17c9 to
f29def3
Compare
|
@ScheererJ @oliver-goetz PTAL :) |
|
Thanks for the changes and explanations. /lgtm |
|
LGTM label has been added. Git tree hash: 9c529c5ba10e25282696e82d48c011f59d02fb15
|
|
/approve 🚀 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Apr 15, 2024
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 31, 2024
(from gardener#9543, released with `v1.93.0`)
Merged
rfranzke
added a commit
to rfranzke/gardener
that referenced
this pull request
May 31, 2024
(from gardener#9543, released with `v1.93.0`)
gardener-prow bot
pushed a commit
that referenced
this pull request
Jun 4, 2024
* Remove deprecated fields from `OperatingSystemConfig` (from #9477, released with `v1.92.0`) * Remove cleanup of old `kube-apiserver` `Ingress` resource (from #9300, released with `v1.91.0`) * Remove Istio zone migration code (from #9304 and #9457, released with `v1.91.0` and `v1.92.0`) * Increase removal period of `<name>.ca-cluster` `Secret` To give users more time to adapt * Remove PVC migration for `garden` Prometheus (from #9543, released with `v1.93.0`) * Remove PVC migration for `longterm` Prometheus (from #9606, released with `v1.94.0`) * Drop migration code in `skaffold.yaml` for `core.gardener.cloud/v1` API (from #9771, released with `v1.96.0`) * Remove migration code for e2e upgrade tests after `provider-local` VPN fix (from #9752, released with `v1.96.0`) * Remove cleanup of old `vali` `VerticalPodAutoscaler`s (from #9681, released with `v1.94.0`) * Remove cleanuop code after making `Secret`s of `ManagedResource`s immutable (from #8116, released with `v1.77.0`) * Remove cleanup code of resources of legacy `cloud-config-downloader` (from #8847, released with `v1.85.0`) * Revert "Remove Istio zone migration code" This reverts commit 8850346. * Increase removal period of Istio zone migration code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity monitoring
/kind enhancement
What this PR does / why we need it:
gardener-operatornow deploys two Prometheus replicas into thegardennamespace. Read more about it here.In addition, a
blackbox-exporterwill be deployed for API server probes. The existingblackboxexportercomponent was made reusable.Which issue(s) this PR fixes:
Part of #9065
Special notes for your reviewer:
/cc @oliver-goetz @ScheererJ
FYI @istvanballok @rickardsjp
Release note:
`gardener-operator` now deploys two Prometheus replicas into the `garden` namespace. Read more about it [here](https://github.com/gardener/gardener/blob/master/docs/concepts/operator.md#observability).