-
Notifications
You must be signed in to change notification settings - Fork 527
Drop UseGardenerNodeAgent
feature gate, cloud-config-{downloader,executor}
, and oscommon
package 🧹
#9477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
UseGardenerNodeAgent
feature gate, cloud-config-{downloader,executor}
, and oscommon
package 🧹🧹UseGardenerNodeAgent
feature gate, cloud-config-{downloader,executor}
, and oscommon
package 🧹
e3a993d
to
84b7c74
Compare
There should be a 🍻 reaction for PRs like this. |
We can 🍻 at the Hackathon then :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome change. Only found a small thing. Looks good otherwise.
pkg/component/extensions/operatingsystemconfig/operatingsystemconfig_test.go
Show resolved
Hide resolved
…ha1.OperatingSystemConfig`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 334d0797a87b012ddb56ff16d31910d2c76311f5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Farewell bash
🧹
-4875 lines...nice cleanup thanks 🚀
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Great release note. Love the list of extension version requirements! |
(from gardener#9477, released with `v1.92.0`)
(from gardener#9477, released with `v1.92.0`)
* Remove deprecated fields from `OperatingSystemConfig` (from #9477, released with `v1.92.0`) * Remove cleanup of old `kube-apiserver` `Ingress` resource (from #9300, released with `v1.91.0`) * Remove Istio zone migration code (from #9304 and #9457, released with `v1.91.0` and `v1.92.0`) * Increase removal period of `<name>.ca-cluster` `Secret` To give users more time to adapt * Remove PVC migration for `garden` Prometheus (from #9543, released with `v1.93.0`) * Remove PVC migration for `longterm` Prometheus (from #9606, released with `v1.94.0`) * Drop migration code in `skaffold.yaml` for `core.gardener.cloud/v1` API (from #9771, released with `v1.96.0`) * Remove migration code for e2e upgrade tests after `provider-local` VPN fix (from #9752, released with `v1.96.0`) * Remove cleanup of old `vali` `VerticalPodAutoscaler`s (from #9681, released with `v1.94.0`) * Remove cleanuop code after making `Secret`s of `ManagedResource`s immutable (from #8116, released with `v1.77.0`) * Remove cleanup code of resources of legacy `cloud-config-downloader` (from #8847, released with `v1.85.0`) * Revert "Remove Istio zone migration code" This reverts commit 8850346. * Increase removal period of Istio zone migration code
How to categorize this PR?
/area open-source
/kind cleanup
What this PR does / why we need it:
UseGardenerNodeAgent
feature gate as well as all migration code related to it.cloud-config-downloader
andcloud-config-executor
bash scripts.Which issue(s) this PR fixes:
Part of #8023
Fixes #4673
Special notes for your reviewer:
/cc @oliver-goetz @ScheererJ
🥂 kudos and many thanks to everybody involved, cc @majst01 @Gerrit91 @timebertt @vknabel and others 🍻
Release note: