Remove catch-all containername matching from prometheus VPAs #9192
Conversation
765afe2 to
158d201
Compare
|
LGTM label has been added. Git tree hash: edbc48ef2c888a4fa8df403062f4e3e648856726
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-v1.89 |
|
@rfranzke: once the present PR merges, I will cherry-pick it on top of release-v1.89 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@rfranzke: new pull request created: #9199 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
How to categorize this PR?
/area auto-scaling
/kind bug
What this PR does / why we need it:
Remove the
containerName: "*"catch-all definition from thecontainerPoliciesfor the prometheus VPAs and move the configuration into the containers explicitly.VPA doesn't actually merge these configurations: as soon as you specify a
containerPolicyfor a specific container name, all configuration undercontainerName: "*"is ignored. This can lead to unwanted cases, for example here you could assume that VPA was configured to scale onlyrequests, but notlimitsfor theprometheuscontainer, but this was not the case. This configuration would only be set for all containers not explicitly mentioned in thecontainerPoliciessection with their name.Release note: