Skip to content

Conversation

rfranzke
Copy link
Member

How to categorize this PR?

/area dev-productivity monitoring
/kind enhancement

What this PR does / why we need it:
This PR

Which issue(s) this PR fixes:
Part of #9065

Special notes for your reviewer:
/cc @timuthy @oliver-goetz
FYI @istvanballok @rickardsjp

Release note:

The `prometheus-operator` (and its related `CustomResourceDefinition`s) are now deployed by default to garden clusters (by `gardener-operator`) and to seed clusters (by `gardenlet`). In the future, it will take over management of the Prometheus and Alertmanager instances.

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) area/monitoring Monitoring (including availability monitoring and alerting) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jan 23, 2024
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR thanks 🚀

Looks good, except the failing operator e2e test 😅

@oliver-goetz
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@oliver-goetz
Copy link
Member

/lgtm cancel
/approve

@istvanballok @rickardsjp please check and lgtm if the PR suits you 😄

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 24, 2024
@oliver-goetz
Copy link
Member

/approve

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 24, 2024
Copy link
Member

@istvanballok istvanballok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos and thank you! :)
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
Copy link
Contributor

gardener-prow bot commented Jan 26, 2024

LGTM label has been added.

Git tree hash: 0a55276261daeeba65c244338d0c7281c4040b7d

Copy link
Contributor

gardener-prow bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: istvanballok, oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants