Skip to content

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

This PR adds a script that one can run if the skaffold dependencies are out of date: hack/update-skaffold-deps.sh.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Hid whitespaces changes when reviewing the second commit.
You can't instruct yq not to indent lists (mikefarah/yq#1309). Hence, running the script reindents the skaffold files.

Release note:

NONE

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Nov 6, 2023
@gardener-prow gardener-prow bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 6, 2023
@timebertt timebertt force-pushed the update-skaffold-deps branch from 12c99a9 to 7dfe716 Compare November 7, 2023 06:46
@timebertt
Copy link
Member Author

/retest

Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks 🚀

@oliver-goetz
Copy link
Member

nice 👍

/lgtm
/approve
/retest

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
Copy link
Contributor

gardener-prow bot commented Nov 10, 2023

LGTM label has been added.

Git tree hash: 1ec7565f032e07bcbc310ac9b493dd9f61bad6a5

Copy link
Contributor

gardener-prow bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@gardener-prow gardener-prow bot merged commit 7060daa into gardener:master Nov 10, 2023
@timebertt timebertt deleted the update-skaffold-deps branch November 10, 2023 12:06
ialidzhikov added a commit to gardener/gardener-extension-registry-cache that referenced this pull request Nov 24, 2023
ialidzhikov added a commit to gardener/gardener-extension-registry-cache that referenced this pull request Nov 27, 2023
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this pull request Nov 27, 2023
ialidzhikov added a commit to ialidzhikov/gardener-extension-registry-cache that referenced this pull request Nov 27, 2023
gardener-prow bot pushed a commit to gardener/gardener-extension-registry-cache that referenced this pull request Nov 27, 2023
* Bump github.com/gardener/gardener from 1.83.2 to 1.84.0

Bumps [github.com/gardener/gardener](https://github.com/gardener/gardener) from 1.83.2 to 1.84.0.
- [Release notes](https://github.com/gardener/gardener/releases)
- [Commits](gardener/gardener@v1.83.2...v1.84.0)

---
updated-dependencies:
- dependency-name: github.com/gardener/gardener
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* [dependabot skip] make revendor

* Vendor gardener/gardener@v1.84.1

* Adapt to the breaking change in the `hack/check-skaffold-deps-for-binary.sh` script

See gardener/gardener#8766

* Address TODO

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: gardener-robot-ci-1 <gardener.ci.user@gmail.com>
Co-authored-by: ialidzhikov <i.alidjikov@gmail.com>
dimitar-kostadinov added a commit to gardener/gardener-extension-registry-cache that referenced this pull request Jun 3, 2024
…ardener#9771.

- Exclude local-setup from the REUSE compliance check.
- Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.
dimitar-kostadinov added a commit to gardener/gardener-extension-registry-cache that referenced this pull request Jun 4, 2024
…dener#9771.

Exclude local-setup from the REUSE compliance check.
Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.
dimitar-kostadinov added a commit to gardener/gardener-extension-registry-cache that referenced this pull request Jun 4, 2024
…dener#9771.

Exclude local-setup from the REUSE compliance check.
Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.
gardener-prow bot pushed a commit to gardener/gardener-extension-registry-cache that referenced this pull request Jun 5, 2024
* Bump github.com/gardener/gardener from 1.95.2 to 1.96.1

Bumps [github.com/gardener/gardener](https://github.com/gardener/gardener) from 1.95.2 to 1.96.1.
- [Release notes](https://github.com/gardener/gardener/releases)
- [Commits](gardener/gardener@v1.95.2...v1.96.1)

---
updated-dependencies:
- dependency-name: github.com/gardener/gardener
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* [GEP-19] Adapt monitoring configuration

* Use `core.gardener.cloud/v1.ControllerDeployment` - ref: gardener/gardener#9771.
Exclude local-setup from the REUSE compliance check.
Fix the skaffold dependencies check - ref: gardener/gardener#9778 & gardener/gardener#8766.

* Fix e2e tests

Ref: gardener/gardener#9752

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dimitar Kostadinov <dimitar.kostadinov@sap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants