Skip to content

Conversation

shafeeqes
Copy link
Contributor

How to categorize this PR?

/area testing
/kind enhancement

What this PR does / why we need it:
Let's include worker pools with in-place update strategy as well in the upgrade test Shoot.

Which issue(s) this PR fixes:
Part of #10219

Special notes for your reviewer:
/cc @acumino @ary1992

Release note:

NONE

This suffix is already appended in `DefaultWorkerlessShoot` function
@gardener-prow gardener-prow bot requested review from acumino and ary1992 June 19, 2025 08:18
@gardener-prow gardener-prow bot added area/testing Testing related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jun 19, 2025
@gardener-prow gardener-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 19, 2025
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2025
Copy link
Contributor

gardener-prow bot commented Jun 19, 2025

LGTM label has been added.

Git tree hash: 20d880b09addd313dadc63f9eb00347aafc2417d

Copy link
Contributor

gardener-prow bot commented Jun 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2025
@ary1992
Copy link
Contributor

ary1992 commented Jun 19, 2025

/retest

@shafeeqes
Copy link
Contributor Author

/test pull-gardener-e2e-kind-gardenadm

@gardener-prow gardener-prow bot merged commit 6227016 into gardener:master Jun 19, 2025
19 checks passed
@shafeeqes shafeeqes deleted the inplace/e2e branch August 26, 2025 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants