Increase timeout for gardenadm init to 10m
#12346
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After gardener#12169, there is another restart of the control plane to activate the NodeAgentAuthorizer webhook (this changes configuration in `kube-apiserver`). Additionally, we have to ensure that `gardener-node-agent` is still running afterwards, and this can take some additional time. In some e2e runs, the current `5m` timeout is simply too short, see for example: - https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/12344/pull-gardener-e2e-kind-gardenadm/1934980463915438080 - https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/12335/pull-gardener-e2e-kind-gardenadm/1934970509573754880 - https://prow.gardener.cloud/view/gs/gardener-prow/pr-logs/pull/gardener_gardener/12318/pull-gardener-e2e-kind-gardenadm/1934964955145048064 or generally https://prow.gardener.cloud/?repo=gardener%2Fgardener&job=pull-gardener-e2e-kind-gardenadm&state=failure, if you are fast enough
|
LGTM label has been added. Git tree hash: cf8ed505ffbfe2d814c0f559c84a63eabdf69a5a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marc1404 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cla |
|
Successfully reached out to cla-assistant.io to initialize recheck of PR #12346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind flake
What this PR does / why we need it:
After #12169, there is another restart of the control plane to activate the NodeAgentAuthorizer webhook (this changes configuration in
kube-apiserver). Additionally, we have to ensure thatgardener-node-agentis still running afterwards, and this can take some additional time.In some e2e runs, the current
5mtimeout is simply too short, see for example:or generally
https://prow.gardener.cloud/?repo=gardener%2Fgardener&job=pull-gardener-e2e-kind-gardenadm&state=failure, if you are fast enough
Special notes for your reviewer:
found w/ @oliver-goetz
Release note: