Rework gardenadm kustomizations (move to /dev-setup)
#12331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 tasks
aa22627 to
9813fc2
Compare
9813fc2 to
6d3a70f
Compare
|
/assign |
timebertt
reviewed
Jun 17, 2025
…ardenadm` In a later commit, they will actually be moved to `/dev-setup/gardenadm/resources`.
It doesn't fit perfectly there since it is not a typical Kustomize component/part, but it doesn't make sense to move it elsewhere, so let's live with it.
…tup/gardenadm/resources` Since this `resources` folder is no typical Kustomize part anyways, let's also move the other files there so that they are at one place.
`/dev-setup/extensions/networking-{calico,cilium}` now have the same
structure like `/dev-setup/extensions/provider-local`
Otherwise, `gardenadm` might complain if we put the generated files into the same directory that also contains the `kustomzation.yaml`: ``` Error: failed reading Kubernetes resources from config directory ./dev-setup/gardenadm/resources/medium-touch: failed reading Kubernetes resources from config directory: failed decoding resource at index 0 in kustomization.yaml: no kind "Kustomization" is registered for version "kustomize.config.k8s.io/v1beta1" in scheme "pkg/runtime/scheme.go:110" exit status 1 ```
6d3a70f to
50717ac
Compare
|
LGTM label has been added. Git tree hash: a733c181a818c3075463400d111a407c9c0cee6c
|
oliver-goetz
approved these changes
Jun 24, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area dev-productivity
/kind cleanup
What this PR does / why we need it:
This PR reworks the dev/e2e setup for
gardenadmin the/dev-setupfolder/dev-setup/gardenadm/machinescontains the machine config for the high-touch scenario (machineStatefulSetand related resources)/dev-setup/gardenadm/resourcesis a Kustomization with overlays for the high-touch and the medium-touch scenariomanifests.yamlfrom theresourcesKustomization, but also the.skaffold-imageand.imagevector-overwrite.yaml) are stored in/dev-setup/gardenadm/resources/generatedNow, there should be no
gardenadmdev/test setup-related config anymore in theexamplefolder.Which issue(s) this PR fixes:
Part of #11958
Special notes for your reviewer:
/cc @timebertt @oliver-goetz
Release note: