Skip to content

Conversation

timebertt
Copy link
Member

@timebertt timebertt commented Jun 10, 2025

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:

In gardenadm bootstrap (GEP-28 medium-touch scenario), gardenadm will be downloaded on the control plane machines from the container registry, similar to how we download gardener-node-agent on shoot machines (see #12267).
For this, we add gardenadm to this repository's container image builds.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

/cc @maboehm @ScheererJ @rfranzke

For actually publishing the container images, refs/meta/ci needs to be updated. We spare the effort for configuring specific branch configs for newer release branches by simply cherry-picking this PR to all active release branches.

  • This commit needs to be pushed after merging this PR (and the cherry-picks): timebertt@01fb453

Release note:

`gardenadm` is now published as a container image in release and snapshot builds.

@gardener-prow gardener-prow bot requested a review from ScheererJ June 10, 2025 13:39
@gardener-prow gardener-prow bot added the area/ipcei IPCEI (Important Project of Common European Interest) label Jun 10, 2025
@gardener-prow gardener-prow bot requested a review from rfranzke June 10, 2025 13:39
@gardener-prow gardener-prow bot added the kind/enhancement Enhancement, improvement, extension label Jun 10, 2025
Copy link
Contributor

gardener-prow bot commented Jun 10, 2025

@timebertt: GitHub didn't allow me to request PR reviews from the following users: maboehm.

Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:

In gardenadm bootstrap (GEP-28 medium-touch scenario), gardenadm will be downloaded on the control plane machines from the container registry, similar to how we download gardener-node-agent on shoot machines (see #12267).
For this, we add gardenadm to this repository's container image builds.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

/cc @maboehm @ScheererJ @rfranzke

For actually publishing the container images, refs/meta/ci needs to be updated. This commit needs to be pushed after merging this PR: timebertt@01fb453
We spare the effort for configuring specific branch configs for newer release branches by simply cherry-picking this PR to all active release branches.

Release note:

`gardenadm` is now published as a container image in release and snapshot builds.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2025
@timebertt
Copy link
Member Author

/cherry-pick release-v1.120

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.120 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.120

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@timebertt
Copy link
Member Author

/cherry-pick release-v1.119

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.119 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.119

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@timebertt
Copy link
Member Author

/cherry-pick release-v1.118

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.118 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ary1992
Copy link
Contributor

ary1992 commented Jun 10, 2025

/retest

@ary1992
Copy link
Contributor

ary1992 commented Jun 10, 2025

/cherry-pick release-v1.121

@gardener-ci-robot
Copy link
Contributor

@ary1992: once the present PR merges, I will cherry-pick it on top of release-v1.121 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.121

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2025
Copy link
Contributor

gardener-prow bot commented Jun 11, 2025

LGTM label has been added.

Git tree hash: 6f949ef14d3efc50ef6b29694faa1b5bde389760

Copy link
Contributor

gardener-prow bot commented Jun 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 11, 2025
@gardener-prow gardener-prow bot merged commit b5b1f57 into gardener:master Jun 11, 2025
19 checks passed
@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #12291

In response to this:

/cherry-pick release-v1.120

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #12292

In response to this:

/cherry-pick release-v1.119

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #12293

In response to this:

/cherry-pick release-v1.118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@ary1992: new pull request created: #12294

In response to this:

/cherry-pick release-v1.121

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants