Skip to content

[GEP-28] gardenadm bootstrap: Deploy OSC to download gardenadm #12267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Jun 17, 2025
Merged

[GEP-28] gardenadm bootstrap: Deploy OSC to download gardenadm #12267

merged 13 commits into from
Jun 17, 2025

Conversation

maboehm
Copy link
Contributor

@maboehm maboehm commented Jun 5, 2025 •
edited by timebertt
Loading

How to categorize this PR?
/area ipcei
/kind enhancement

What this PR does / why we need it:
This PR continues #12196 and deploys an OperatingSystemConfig which downloads the gardenadm binary similar to how the node-agent itself is downloaded.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:
/cc @rfranzke @ScheererJ @timebertt

Tim mentioned there are some more steps needed to actually publish the gardenadm docker image. I guess someone with knowledge and permission needs to configure this.
EDIT: moved to #12287

We originally planned to also add the bootstrap manifests to the OSC, but in the local setup they are at 18k due to the embedded helm charts, so we will probably have to push them via the bastion.

Release note:

NONE

@gardener-prow gardener-prow bot added area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 5, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 5, 2025

Hi @maboehm. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 5, 2025
@rfranzke
Copy link
Member

rfranzke commented Jun 6, 2025

/assign
/ok-to-test

@gardener-prow gardener-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 6, 2025
@timebertt timebertt mentioned this pull request Jun 10, 2025
Open
timebertt
timebertt reviewed Jun 10, 2025
View reviewed changes
Copy link
Member

@timebertt timebertt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this PR!
I found a few things, we might still want to improve :)

/assign

@timebertt timebertt force-pushed the gardenadm-bootstrap-osc branch from 7bde20b to 06c34e6 Compare June 10, 2025 13:31
@timebertt timebertt mentioned this pull request Jun 10, 2025
Merged
1 task
@timebertt
Copy link
Member

I extracted the commit for adding the gardenadm image build to a dedicated PR: #12287

rfranzke
rfranzke reviewed Jun 11, 2025
View reviewed changes
@maboehm
Copy link
Contributor Author

maboehm commented Jun 13, 2025

I am on vacation next week. @timebertt will take over to get this finished.
From my POV I addressed the Feedback.
The failed integration tests are probably a flake, at least locally it worked.
The E2E test also looks like its unrelated to my changes.

@timebertt
Copy link
Member

@rfranzke I reviewed the latest changes and pushed a few nits.
Handing back to you for the final review ;)

rfranzke
rfranzke reviewed Jun 16, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nit, otherwise lgtm

@timebertt timebertt requested a review from rfranzke June 16, 2025 13:18
@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 16, 2025

LGTM label has been added.

Git tree hash: 1974ec1b245166fe994229d44e05a11d87845acb

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@timebertt
Copy link
Member

/retest

@gardener-prow gardener-prow bot merged commit 6bf864d into gardener:master Jun 17, 2025
19 checks passed
@timebertt timebertt deleted the gardenadm-bootstrap-osc branch June 17, 2025 08:09
@timebertt timebertt mentioned this pull request Jun 27, 2025
Merged
1 task
@timebertt timebertt mentioned this pull request Aug 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timebertt timebertt timebertt left review comments

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

@rfranzke rfranzke Awaiting requested review from rfranzke

Assignees

@rfranzke rfranzke

@timebertt timebertt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maboehm @rfranzke @timebertt