Restrict Shoot Prometheus RBAC to control-plane namespace #12264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ialidzhikov
reviewed
Jun 9, 2025
|
/hold |
|
@chrkl , can we remove the hold now and review the PR again? Or is there a particular reason you hold the PR? |
|
@ialidzhikov We identified that these changes break the alertmanager discovery mechanism. I am still working on the PR. |
All Prometheus instances were deployed with the recommended ClusterRole from the Prometheus-Operator documentation (https://prometheus-operator.dev/docs/platform/rbac/#prometheus-rbac). This grants cluster wide access for Shoot Prometheus instances, which is not required. This commit introduces a namespace scoped Role for Shoot Prometheus instances.
|
/unhold |
|
/lgtm |
|
LGTM label has been added. Git tree hash: ec491cebaaf2b4f96ff06791976df64c7383917e
|
|
@ialidzhikov could you review again? Thanks! |
|
LGTM label has been added. Git tree hash: 8dfb224bbdbc07ddaa61976e55f72dc96511a587
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
…2264) * Restrict Shoot Prometheus permissions to namespace All Prometheus instances were deployed with the recommended ClusterRole from the Prometheus-Operator documentation (https://prometheus-operator.dev/docs/platform/rbac/#prometheus-rbac). This grants cluster wide access for Shoot Prometheus instances, which is not required. This commit introduces a namespace scoped Role for Shoot Prometheus instances. * Apply reviewer suggestions * Fixed condition to deploy shoot Role and RoleBinding * Grant Shoot Prometheus read access to Services in garden namespace * Clarify used namespace by code comment * Avoid usage of constants in unit tests --------- Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
All Prometheus instances were bound to a ClusterRole that grants read access to all Nodes, Services, Endpoints, and Pods. The Shoot specific Prometheus instances do not need access to all namespaces but only the shoot specific and the garden namespace in the Seed cluster. This PR introduces a namespace scoped Role and RoleBinding for the Shoot Prometheus instances.
Which issue(s) this PR fixes:
Fixes gardener/monitoring#50
Special notes for your reviewer:
/cc @vicwicker @istvanballok @rickardsjp
Release note: