[release-v1.120] Fix credentials rotation without workers rollout for in-place update #12249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrongly replaced in gardener#11990
…manual in-place pending workers are updated
|
/lgtm |
|
LGTM label has been added. Git tree hash: 730258d0eac055dc20d51a2ecc8b6cf74c720603
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
Wieneo
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Jun 6, 2025
… in-place update (gardener#12249) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in gardener#11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
ske-prow bot
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Jun 6, 2025
* [release-v1.120] Fix credentials rotation without workers rollout for in-place update (gardener#12249) * Use correct lastInitationTime during credentials rotation without workers rollout * Use correct function in e2e test This was wrongly replaced in gardener#11990 * Add e2e tests for in-place and without-workers-rollout combination * Reconcile shoot when rotation status is WaitingForWorkersRollout and manual in-place pending workers are updated --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> * Release v1.120.1 --------- Co-authored-by: Gardener Prow Robot <gardener.ci.robot@gmail.com> Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com> Co-authored-by: gardener-robot-ci-2 <gardener.ci.user2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #12241
/assign shafeeqes