feat: Support for Kubernetes v1.33 #12216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
rfranzke
reviewed
Jun 2, 2025
|
LGTM label has been added. Git tree hash: 851fdc6079d9b44ce209431f88634a84cb0a107a
|
|
/assign |
|
/assign |
21 tasks
0c8a07e to
f0881da
Compare
f0881da to
82bb801
Compare
|
/retest |
Co-authored-by: Kostov6 <v.kostov@sap.com>
Testing with a workerless shoot with version 1.32 ``` k -n shoot--local--local-wl logs kube-controller-manager-5d75d66f-8qmvz | tail -n 1 E0529 09:15:38.793384 1 run.go:72] "command failed" err="\"device-taint-eviction-controller\" is not in the list of known controllers" ``` This is because in the KCM deployment device-taint-eviction-controller was specified in the command line flags as a controller to be disabled, more specifically as -device-taint-eviction-controller Co-authored-by: Kostov6 <v.kostov@sap.com>
fb04740 to
bdf51bf
Compare
ialidzhikov
reviewed
Jun 16, 2025
6337bcb to
dac0234
Compare
ialidzhikov
reviewed
Jun 17, 2025
There was a problem hiding this comment.
Looks awesome! Let's resolve the open comments and include this PR for Gardener v1.122.
Overall, all my comments are doc and wording suggestions in the new-kubernetes-version.md guide (the previous review from yesterday), and a single suggestion in the shoot_kubernetes_versions.md guide.
|
LGTM label has been added. Git tree hash: c4809dcad49af238bcceec2660161e9ec645037a
|
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ialidzhikov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area open-source
/kind enhancement
What this PR does / why we need it:
Support for Kubernetes v1.33.
Which issue(s) this PR fixes:
Part of #11933
Special notes for your reviewer:
Note: please check the last commit before the
chore: Maintain kube-controller-manager controllerscommit as they are relatedWe performed the changes by following the new Kubernetes version guide and comparing how changes have been done for previous Kubernetes versions, e.g., #11197. We also used a new version of
compare-k8s-feature-gates.sh, introduced with #12109.Code changes have been tested in the following scenarios using the local provider:
Related PR for Network Policy issue found during local testing: #12215
Release note: