-
Notifications
You must be signed in to change notification settings - Fork 526
Allow gardener admins to manage services and endpoints in the virtual cluster #12211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow gardener admins to manage services and endpoints in the virtual cluster #12211
Conversation
@ialidzhikov: GitHub didn't allow me to request PR reviews from the following users: donistz. Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I have no strong opinion, but another approach would be to only allow access to the said service
and endpoint
. If that is too much work or if it would bring additional complexity w.r.t. role assignments I guess this change is also good enough as it is.
/hold |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
9a46c97
to
38aa177
Compare
I was wondering the same when creating the PR. It might be also a feature for the |
/hold cancel |
/test pull-gardener-unit |
The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
You can:
/lifecycle stale |
/remove-lifecycle stale |
@dimityrmirchev @vpnachev @gardener/gardener-maintainers any feedback on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable.
/lgtm
LGTM label has been added. Git tree hash: ca0018bffd529b0162bc524461a705c0af2f4447
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dimityrmirchev, tobschli, vpnachev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area security
/kind enhancement
What this PR does / why we need it:
gardener-operator creates
kube-system/gardener-apiserver
Service andkube-system/gardener-apiserver
Endpoint in the virtual cluster:gardener/pkg/component/gardener/apiserver/service.go
Lines 42 to 59 in 485c251
gardener/pkg/component/gardener/apiserver/endpoints.go
Lines 12 to 29 in 485c251
gardener/pkg/component/gardener/apiserver/apiserver.go
Lines 193 to 206 in 485c251
However, gardener admins currently don't have permissions to inspect or mutate these resources.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
I don't know at all what is the use case of these Service and Endpoint. Let me know if they are not used. Let me know also what is their use case - it would be interesting to learn this.EDIT: The APIService points to the kube-system/gardener-apiserver Service. The underlying Endpoint resolves to the clusterIP of the garden/gardener-apiserver Service in the runtime cluster.
Release note: