Skip to content

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area ipcei
/kind enhancement

What this PR does / why we need it:

This PR continues #12152 and deploys the Worker for control plane machines in gardenadm bootstrap.

Which issue(s) this PR fixes:
Part of #2906

Special notes for your reviewer:

/cc @rfranzke @ScheererJ

There is no real OperatingSystemConfig and the Machines won't get ready yet.
I added a dummy OSC (based on the PoC code) for testing the Worker deployment in this PR.
And the Machines won't get ready until gardener/machine-controller-manager#994 is implemented and released.
This PR will serve as a good basis for implementing and testing a real OSC and the needed changes in mcm in separate PRs.

Also, the dnsconfig webhook of provider-local is fully disabled now for autonomous shoots, as we don't need any DNS handling yet. Hence, I reverted f54c81b.

Release note:

NONE

@gardener-prow gardener-prow bot requested review from rfranzke and ScheererJ May 28, 2025 07:20
@gardener-prow gardener-prow bot added area/ipcei IPCEI (Important Project of Common European Interest) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 28, 2025
@timebertt timebertt changed the title Gardenadm bootstrap worker [GEP-28] gardenadm bootstrap: Deploy Worker May 28, 2025
@timebertt timebertt force-pushed the gardenadm-bootstrap-worker branch 2 times, most recently from a32e289 to 4ea1d8a Compare May 28, 2025 07:51
@rfranzke
Copy link
Member

/assign

@timebertt timebertt force-pushed the gardenadm-bootstrap-worker branch from 4ea1d8a to a079e13 Compare May 28, 2025 08:22
@ScheererJ
Copy link
Member

/assign

Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving GEP-28 forward.

@timebertt timebertt force-pushed the gardenadm-bootstrap-worker branch from 6749d85 to d55d197 Compare May 28, 2025 13:59
@ScheererJ
Copy link
Member

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
Copy link
Contributor

gardener-prow bot commented May 28, 2025

LGTM label has been added.

Git tree hash: a6f399d1c75506fc43dbb185b98ae785fbb2d1d6

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

gardener-prow bot commented Jun 2, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 2, 2025
timebertt added 5 commits June 2, 2025 17:53
Usually, the machine image is defaulted from the `CloudProfile`. This doesn't happen in
gardenadm, so we need to specify the fields.
This reverts commit gardener@f54c81b

It is no longer needed to label the high-touch machine pods differently, as the `dnsconfig` webhook is entirely
disabled for gardenadm now.
@rfranzke rfranzke force-pushed the gardenadm-bootstrap-worker branch from d55d197 to 25ffcce Compare June 2, 2025 15:54
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 2, 2025
@gardener-prow gardener-prow bot requested review from rfranzke and ScheererJ June 2, 2025 15:54
@rfranzke
Copy link
Member

rfranzke commented Jun 2, 2025

/lgtm

@gardener-prow gardener-prow bot added lgtm Indicates that a PR is ready to be merged. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 2, 2025
Copy link
Contributor

gardener-prow bot commented Jun 2, 2025

LGTM label has been added.

Git tree hash: 1c9a7585469d4576e3dff6cfd8a07bcdf935c2a6

@gardener-prow gardener-prow bot merged commit eb77abe into gardener:master Jun 2, 2025
19 checks passed
@timebertt timebertt deleted the gardenadm-bootstrap-worker branch June 10, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipcei IPCEI (Important Project of Common European Interest) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants