-
Notifications
You must be signed in to change notification settings - Fork 525
[GEP-28] gardenadm bootstrap
: Deploy Worker
#12196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GEP-28] gardenadm bootstrap
: Deploy Worker
#12196
Conversation
gardenadm bootstrap
: Deploy Worker
a32e289
to
4ea1d8a
Compare
/assign |
4ea1d8a
to
a079e13
Compare
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving GEP-28 forward.
6749d85
to
d55d197
Compare
/lgtm |
LGTM label has been added. Git tree hash: a6f399d1c75506fc43dbb185b98ae785fbb2d1d6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Usually, the machine image is defaulted from the `CloudProfile`. This doesn't happen in gardenadm, so we need to specify the fields.
This reverts commit gardener@f54c81b It is no longer needed to label the high-touch machine pods differently, as the `dnsconfig` webhook is entirely disabled for gardenadm now.
d55d197
to
25ffcce
Compare
/lgtm |
LGTM label has been added. Git tree hash: 1c9a7585469d4576e3dff6cfd8a07bcdf935c2a6
|
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR continues #12152 and deploys the
Worker
for control plane machines ingardenadm bootstrap
.Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
/cc @rfranzke @ScheererJ
There is no real
OperatingSystemConfig
and theMachines
won't get ready yet.I added a dummy OSC (based on the PoC code) for testing the
Worker
deployment in this PR.And the
Machines
won't get ready until gardener/machine-controller-manager#994 is implemented and released.This PR will serve as a good basis for implementing and testing a real OSC and the needed changes in mcm in separate PRs.
Also, the
dnsconfig
webhook of provider-local is fully disabled now for autonomous shoots, as we don't need any DNS handling yet. Hence, I reverted f54c81b.Release note: