Skip to content

Conversation

acumino
Copy link
Member

@acumino acumino commented May 26, 2025

How to categorize this PR?

/area testing
/kind bug

What this PR does / why we need it:
Pass the disable-webhooks only once when the cluster is not runtime cluster.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Introduced in #12156
/cc @rfranzke

Release note:

NONE

@gardener-prow gardener-prow bot requested a review from rfranzke May 26, 2025 09:19
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/testing Testing related kind/bug Bug size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 26, 2025
Copy link
Member

@timuthy timuthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2025
Copy link
Contributor

gardener-prow bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timuthy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

gardener-prow bot commented May 26, 2025

LGTM label has been added.

Git tree hash: 263538e92823df4929edcb549f5bd0374dd92743

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@gardener-prow gardener-prow bot merged commit 49be404 into gardener:master May 26, 2025
19 checks passed
@shafeeqes shafeeqes deleted the fix-dep branch May 27, 2025 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Testing related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants