Skip to content

Make gardener-operator and Garden scenario work on single-node kind cluster #12138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Make gardener-operator and Garden scenario work on single-node kind cluster #12138

wants to merge 1 commit into from

Conversation

MartinWeindel
Copy link
Member

@MartinWeindel MartinWeindel commented May 19, 2025 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:
Addresses 'Make gardener-operator and Garden scenario work on single-node kind cluster' of #11958
with

make kind-operator-single-up operator-up operator-seed-single-up

Which issue(s) this PR fixes:
Part of #11958

Special notes for your reviewer:

Release note:

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 19, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/dev-productivity Developer productivity related (how to improve development) labels May 19, 2025
@gardener-prow gardener-prow bot requested review from acumino and tobschli May 19, 2025 08:42
@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 19, 2025
@rfranzke
Copy link
Member

/assign

@rfranzke rfranzke changed the title Introduce single-node kind-cluster based on gardener-operator Make gardener-operator and Garden scenario work on single-node kind cluster May 19, 2025
@rfranzke rfranzke mentioned this pull request May 19, 2025
Open
23 tasks
rfranzke
rfranzke requested changes May 19, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference with this setup compared to make kind-up?

@rfranzke
Copy link
Member

/assign @oliver-goetz @rfranzke

@MartinWeindel MartinWeindel force-pushed the enh/operator-single-seed branch from 03d1161 to deacc7e Compare May 27, 2025 11:14
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from oliver-goetz. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MartinWeindel MartinWeindel force-pushed the enh/operator-single-seed branch from deacc7e to bfb2e18 Compare May 27, 2025 11:24
@MartinWeindel
Copy link
Member Author

What is the difference with this setup compared to make kind-up?

The make kind-operator-single-up is quite similar to make kind-operator-up. The only difference is that there is only one zone instead of three. See example/operator-single/patch-garden.yaml

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 11, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jun 11, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

The Gardener project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:

  • After 15d of inactivity, lifecycle/stale is applied
  • After 15d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 7d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Mark this PR as rotten with /lifecycle rotten
  • Close this PR with /close

/lifecycle stale

@gardener-prow gardener-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 26, 2025
@rfranzke rfranzke mentioned this pull request Jul 2, 2025
Merged
@rfranzke
Copy link
Member

rfranzke commented Jul 2, 2025

Thanks for the work, I have incorporated/translated the changes into #12439. We can continue there! :)
/close

@gardener-prow gardener-prow bot closed this Jul 2, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Jul 2, 2025

@rfranzke: Closed this PR.

In response to this:

Thanks for the work, I have incorporated/translated the changes into #12439. We can continue there! :)
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke requested changes

@acumino acumino Awaiting requested review from acumino

@tobschli tobschli Awaiting requested review from tobschli

Assignees

@rfranzke rfranzke

@oliver-goetz oliver-goetz

Labels
area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MartinWeindel @rfranzke @gardener-ci-robot @oliver-goetz