[release-v1.118] Drop annotations and labels for referenced resources #12064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of only removing the `kubectl.kubernetes.io/last-applied-configuration` annotation, we can simply ignore all labels and annotations from the source object. Co-Authored-By: Johannes Scheerer <johannes.scheerer@sap.com> Co-Authored-By: Tim Usner <tim.usner@sap.com>
|
/lgtm |
|
LGTM label has been added. Git tree hash: a7f205ee32f4cc075fdcd858ab3e57721ff4aafa
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
timebertt
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
May 14, 2025
backport of gardener#12056 Can be dropped when upgrading to g/g@v1.119 Instead of only removing the `kubectl.kubernetes.io/last-applied-configuration` annotation, we can simply ignore all labels and annotations from the source object. Co-authored-by: rfranzke <rafael.franzke@sap.com> Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com> Co-authored-by: Tim Usner <tim.usner@sap.com>
ske-prow bot
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
May 14, 2025
backport of gardener#12056 Can be dropped when upgrading to g/g@v1.119 Instead of only removing the `kubectl.kubernetes.io/last-applied-configuration` annotation, we can simply ignore all labels and annotations from the source object. Co-authored-by: rfranzke <rafael.franzke@sap.com> Co-authored-by: Johannes Scheerer <johannes.scheerer@sap.com> Co-authored-by: Tim Usner <tim.usner@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #12056
/assign rfranzke