Skip to content

Restrict project owner change #12062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2025
Merged

Restrict project owner change #12062

merged 1 commit into from
May 14, 2025

Conversation

timuthy
Copy link
Member

@timuthy timuthy commented May 13, 2025

How to categorize this PR?

/area robustness
/kind enhancement

What this PR does / why we need it:
Only allow the owner itself or users with UAM role to change the owner of a project.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
/cc @rfranzke

Release note:

A new check ensures that only owners and project members with a UAM role are allowed to modify the project owner.

@gardener-prow gardener-prow bot requested a review from rfranzke May 13, 2025 09:56
@gardener-prow gardener-prow bot added area/robustness Robustness, reliability, resilience related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 13, 2025
@timuthy
Copy link
Member Author

timuthy commented May 13, 2025

Relevant for upcoming release.
/cc @LucaBernstein

@gardener-prow gardener-prow bot requested a review from LucaBernstein May 13, 2025 09:57
@timuthy
Copy link
Member Author

timuthy commented May 13, 2025

/cherry-pick release-v1.118

@gardener-ci-robot
Copy link
Contributor

@timuthy: once the present PR merges, I will cherry-pick it on top of release-v1.118 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@timuthy
Copy link
Member Author

timuthy commented May 13, 2025

/cherry-pick release-v1.117

@gardener-ci-robot
Copy link
Contributor

@timuthy: once the present PR merges, I will cherry-pick it on top of release-v1.117 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@timuthy
Copy link
Member Author

timuthy commented May 13, 2025

/cherry-pick release-v1.116

@gardener-ci-robot
Copy link
Contributor

@timuthy: once the present PR merges, I will cherry-pick it on top of release-v1.116 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@rfranzke
Copy link
Member

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 13, 2025

LGTM label has been added.

Git tree hash: ce294181796aeffe3013d58c2f3b70a926f862a3

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
@rfranzke
Copy link
Member

/retest

@timuthy
Copy link
Member Author

timuthy commented May 14, 2025

/test pull-gardener-e2e-kind-gardenadm

@gardener-prow gardener-prow bot merged commit fb3f728 into gardener:master May 14, 2025
19 checks passed
@gardener-ci-robot
Copy link
Contributor

@timuthy: new pull request created: #12081

In response to this:

/cherry-pick release-v1.116

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request May 14, 2025
Merged
@gardener-ci-robot
Copy link
Contributor

@timuthy: new pull request created: #12082

In response to this:

/cherry-pick release-v1.118

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request May 14, 2025
Merged
@gardener-ci-robot
Copy link
Contributor

@timuthy: new pull request created: #12083

In response to this:

/cherry-pick release-v1.117

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request May 14, 2025
Merged
@timuthy timuthy deleted the enh/project-owner-uam branch May 14, 2025 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke Awaiting requested review from rfranzke

@LucaBernstein LucaBernstein Awaiting requested review from LucaBernstein

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/robustness Robustness, reliability, resilience related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timuthy @gardener-ci-robot @rfranzke