Skip to content

Conversation

acumino
Copy link
Member

@acumino acumino commented May 13, 2025

How to categorize this PR?

/area control-plane delivery open-source scalability
/kind enhancement

What this PR does / why we need it:
When NewWorkerPoolHash feature gate is set to false, shoots are created with OSC version 1, This PR makes the necessary change so the shoots with OSCs version 1 can also be updated inplace.

Which issue(s) this PR fixes:
Part of #10219

Special notes for your reviewer:

Release note:

NONE

@gardener-prow gardener-prow bot added area/control-plane Control plane related area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 13, 2025
@gardener-prow gardener-prow bot requested review from plkokanov and tobschli May 13, 2025 06:06
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 13, 2025
@acumino
Copy link
Member Author

acumino commented May 13, 2025

/cc @shafeeqes @ary1992

@rfranzke
Copy link
Member

/assign

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

gardener-prow bot commented May 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2025
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
Copy link
Contributor

gardener-prow bot commented May 13, 2025

LGTM label has been added.

Git tree hash: e72d4665361a5684b203463778a0311aa4e5825c

@gardener-prow gardener-prow bot merged commit 414264d into gardener:master May 13, 2025
19 checks passed
@shafeeqes shafeeqes deleted the workerPool-Keyv1 branch May 13, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related area/delivery Delivery related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants