-
Notifications
You must be signed in to change notification settings - Fork 525
[GEP-28] Preparations for etcd-druid
taking over management of etcd
#12038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
etcd-druid
taking over management of etcd
etcd-druid
taking over management of etcd
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for preparing the etcd take-over.
It looks good already, but I would like to understand the reasoning for the special image vector override.
This is not allowed for mirror pods
We just mount a path from the host instead.
- change names from `etcd-<role>-0` to `etcd-bootstrap-<role>` to make it more clear when `kubectl get pod` - use the same data directory that etcd managed by etcd-druid would use later (it shall just take over the existing data dir)
- With gardener@f9f6a46 (part of gardener#11853) we only skipped static pods during the bootstrap phase. However, we actually never want GRM webhooks to react on static pod creations, even if we are beyond the bootstrap phase. Otherwise, the kubelet might fail to create mirror pods for control plane components if the GRM webhook is unavailable. This can lead to undesired behaviour.
- Otherwise, we might get issues when etcd-druid takes over etcd management later - Review this commit with `git diff -w` (ignoring whitespaces) - `yq` seems to enforce indentation, so let's live with it Output: $ go generate ./imagevector/imagevector.go containers.go Cloning etcd-druid... Found etcd-wrapper tag: v0.4.4 Cloning etcd-wrapper at tag v0.4.4... Found etcd version string: v0.0.0-20240911181550-c123b3ea3db3 Extracted commit hash: c123b3ea3db3 Cloning etcd repo to resolve tag... Resolved etcd tag: v3.4.34 Updating containers.yaml with etcd v3.4.34 tag charts.go
@ScheererJ Any further feedback? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: c3740a0683d900e7295917f4e612ef65d1c56d8b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR prepares for
etcd-druid
taking over management ofetcd
(this itself is not yet part of this PR and will follow later).Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
/cc @ScheererJ @timebertt
Release note: