Skip to content

Improve utilization of vpn-seed-server, vpn-client-* and vpn-path-controller. #12023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 14, 2025
Merged

Improve utilization of vpn-seed-server, vpn-client-* and vpn-path-controller. #12023

merged 3 commits into from
May 14, 2025

Conversation

axel7born
Copy link
Contributor

@axel7born axel7born commented May 7, 2025 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area networking
/kind enhancement

What this PR does / why we need it:

  • Remove MinAllowed from VPA configuration of vpn-seed-server
  • Remove limits
  • Reduce initial/static requests
  • Switch container openvpn-exporter to mode Off

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The utilization of the VPN containers running in the seed is now improved by adapting their initial/static requests and by changing the corresponding VPA configuration:
- autoscaling is disabled for the `vpn-seed-server` and `openvpn-exporter` containers
- initial/static resource requests are reduced
- limits are removed
- `minAllowed` for the `envoy-proxy` container is removed

@gardener-prow gardener-prow bot added area/networking Networking related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 7, 2025
@gardener-prow gardener-prow bot requested review from shafeeqes and tobschli May 7, 2025 15:28
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 7, 2025
@axel7born
Copy link
Contributor Author

/invite @vlerenc

@ialidzhikov
Copy link
Member

/assign

@ialidzhikov ialidzhikov mentioned this pull request May 8, 2025
Merged
ialidzhikov
ialidzhikov reviewed May 8, 2025
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I will continue the review tomorrow.

@gardener-prow gardener-prow bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 9, 2025
@axel7born axel7born changed the title Improve utiliazation of vpn-seed-server, vpn-client-* and vpn-path-controller. Improve utilization of vpn-seed-server, vpn-client-* and vpn-path-controller. May 9, 2025
@ialidzhikov
Copy link
Member

pull-gardener-unit failed due to timeout:

{"component":"entrypoint","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:169","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.ExecuteProcess","level":"error","msg":"Process did not finish before 40m0s timeout","severity":"error","time":"2025-05-09T11:05:14Z"}

I will check whether it makes sense to increase the timeout of the job 👀

/test pull-gardener-unit

@ialidzhikov
Copy link
Member

https://prow.gardener.cloud/?repo=gardener%2Fgardener&job=ci-gardener-unit :

Screenshot 2025-05-12 at 10 21 16

https://prow.gardener.cloud/?repo=gardener%2Fgardener&job=pull-gardener-unit :

Screenshot 2025-05-12 at 10 21 58

It usually takes < 30m. Hence, the timeout of 40m should be fine.

@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
ialidzhikov
ialidzhikov reviewed May 12, 2025
View reviewed changes
axel7born added 2 commits May 12, 2025 10:03
@axel7born
Disable VPA for container vpn-seed-server
955c278 
Container vpn-seed-server has not a significant resource consumption.
For HA VPN there is no container left, that needs scaling.
Update mode can be switched to `Off`.
@axel7born
Adapt requests
14dae81 
* static requests for vpn-seed-server to 10m/7.5M
* initial requests for envoy container to 10m
@axel7born axel7born force-pushed the vpn-resources-requests branch from 0766cf7 to 14dae81 Compare May 12, 2025 08:15
@gardener-prow gardener-prow bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2025
ialidzhikov
ialidzhikov reviewed May 12, 2025
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for addressing my review suggestions!

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 12, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 12, 2025

LGTM label has been added.

Git tree hash: 2f3988ab5b47b26ae2e1c4e0dbe8cfdc693f008a

@axel7born
Copy link
Contributor Author

/test pull-gardener-integration

ScheererJ
ScheererJ approved these changes May 12, 2025
View reviewed changes
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the resource improvements.

/assign

/lgtm
/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 12, 2025
@axel7born
Copy link
Contributor Author

/test pull-gardener-integration

@gardener-prow gardener-prow bot merged commit c003646 into gardener:master May 14, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov left review comments

@ScheererJ ScheererJ ScheererJ approved these changes

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

@tobschli tobschli Awaiting requested review from tobschli

Assignees

@ialidzhikov ialidzhikov

@ScheererJ ScheererJ

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@axel7born @ialidzhikov @ScheererJ