Skip to content

Conversation

oliver-goetz
Copy link
Member

How to categorize this PR?

/area auto-scaling cost
/kind enhancement

What this PR does / why we need it:
With this PR Gardener enforces spreading Istio ingress-gateway pods across hosts only for zonal deployments.
For zonal Istio ingress-gateway deployments this enforcement is beneficial for the availability of the endpoints served by Istio since the failure of a single node does not lead to unavailable endpoints.
In case of regional Istio ingress-gateway deployments there are at least 4 other pods in the other zones even when the distribution across nodes is only preferred since we enforce a zonal spread in this case anyway. This saves some resources in the Garden runtime cluster and on small HA Seeds since it reduces the minimum node count from 6 to 3.

Additionally, this PR removes the pod anti affinity since according to the Gardener component check list it is best practice to add HA relevant settings via GRM HA webhook.

Which issue(s) this PR fixes:
Part of #8810

Special notes for your reviewer:

Release note:

Spreading Istio ingress-gateway pods across hosts is enforced only for zonal Istio deployments now.

@gardener-prow gardener-prow bot added area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/cost Cost related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels May 5, 2025
@gardener-prow gardener-prow bot requested review from plkokanov and ScheererJ May 5, 2025 16:44
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 5, 2025
@ScheererJ
Copy link
Member

/assign

Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into how we can reduce the resource footprint.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
Copy link
Contributor

gardener-prow bot commented May 6, 2025

LGTM label has been added.

Git tree hash: 1798d6884d701e0a14961afb1876a9cd81d704ee

Copy link
Contributor

gardener-prow bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@gardener-prow gardener-prow bot merged commit 2096a3b into gardener:master May 6, 2025
19 checks passed
@oliver-goetz oliver-goetz deleted the enh/istio-gateway-scheduling branch May 7, 2025 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/cost Cost related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants