Skip to content

[GEP-31] Add usage doc for in-place update #12005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 28, 2025
Merged

[GEP-31] Add usage doc for in-place update #12005

merged 5 commits into from
May 28, 2025

Conversation

ary1992
Copy link
Contributor

@ary1992 ary1992 commented May 5, 2025

How to categorize this PR?

/area documentation
/kind enhancement

What this PR does / why we need it:
Adds usage doc for in-place update under shoot_updates.md file.

Which issue(s) this PR fixes:
Part of #10219

Special notes for your reviewer:

Release note:

NONE

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 5, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/documentation Documentation related kind/enhancement Enhancement, improvement, extension labels May 5, 2025
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 5, 2025
@shafeeqes shafeeqes mentioned this pull request May 5, 2025
Closed
40 tasks
@ary1992 ary1992 force-pushed the inplace-updates-doc branch from ea48969 to f6ae6e5 Compare May 13, 2025 07:37
@ary1992 ary1992 marked this pull request as ready for review May 13, 2025 07:37
@gardener-prow gardener-prow bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 13, 2025
@gardener-prow gardener-prow bot requested a review from LucaBernstein May 13, 2025 07:37
@gardener-prow gardener-prow bot added cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. and removed cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. cla: no Indicates the PR's author has not signed the cla-assistant.io CLA. labels May 13, 2025
LucaBernstein
LucaBernstein reviewed May 13, 2025
View reviewed changes
shafeeqes
shafeeqes reviewed May 13, 2025
View reviewed changes
@ary1992 ary1992 force-pushed the inplace-updates-doc branch 3 times, most recently from 3729a7b to 0c271e6 Compare May 15, 2025 09:46
@ary1992
Copy link
Contributor Author

ary1992 commented May 16, 2025

/retest

@ary1992 ary1992 force-pushed the inplace-updates-doc branch from 0c271e6 to f0bfaa3 Compare May 16, 2025 10:55
acumino
acumino requested changes May 16, 2025
View reviewed changes
@ary1992 ary1992 force-pushed the inplace-updates-doc branch from bb158c8 to 1d3c96d Compare May 21, 2025 14:24
@rfranzke rfranzke requested review from shafeeqes and acumino May 22, 2025 05:26
rfranzke
rfranzke reviewed May 22, 2025
View reviewed changes
shafeeqes
shafeeqes requested changes May 22, 2025
View reviewed changes
shafeeqes
shafeeqes reviewed May 23, 2025
View reviewed changes
Copy link
Contributor

@shafeeqes shafeeqes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 23, 2025
@shafeeqes shafeeqes requested a review from rfranzke May 23, 2025 09:55
@ary1992
Copy link
Contributor Author

ary1992 commented May 27, 2025

/retest

@shafeeqes
Copy link
Contributor

@rfranzke, Can we continue with this PR?

acumino
acumino requested changes May 28, 2025
View reviewed changes
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@gardener-prow gardener-prow bot requested review from acumino and shafeeqes May 28, 2025 05:01
acumino
acumino reviewed May 28, 2025
View reviewed changes
Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 28, 2025

LGTM label has been added.

Git tree hash: 7ab72f64cbd3afbd86add01a91e5b0c70daf2eae

@ary1992
Copy link
Contributor Author

ary1992 commented May 28, 2025

/retest

@rfranzke
Copy link
Member

/approve
/retest

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@gardener-prow gardener-prow bot merged commit b236e35 into gardener:master May 28, 2025
19 checks passed
@ary1992 ary1992 deleted the inplace-updates-doc branch May 28, 2025 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaBernstein LucaBernstein LucaBernstein left review comments

@acumino acumino acumino requested changes

@ialidzhikov ialidzhikov Awaiting requested review from ialidzhikov

@oliver-goetz oliver-goetz Awaiting requested review from oliver-goetz

@rfranzke rfranzke Awaiting requested review from rfranzke

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

Assignees

@acumino acumino

@shafeeqes shafeeqes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Documentation related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ary1992 @shafeeqes @rfranzke @LucaBernstein @acumino