Skip to content

Conversation

Kostov6
Copy link
Contributor

@Kostov6 Kostov6 commented Aug 22, 2025

How to categorize this PR?

/area quality
/kind bug

What this PR does / why we need it:
Seems to be caused by #12762

This PR suffixes plutono-datasources when OnlyDeployDataSourcesAndDashboards is set mirroring the behavior of the data field

Data: map[string]string{"datasources" + dataSourcesKeySuffix + ".yaml": p.getDataSource()},

Which issue(s) this PR fixes:
Fixes #12785

Special notes for your reviewer:
Result after running local operator setup

❯ k -n garden get configmap | grep plutono
plutono-dashboard-providers-140e41f3                1      8m6s
plutono-dashboards-garden                           31     8m6s
plutono-dashboards-seed                             18     96s
plutono-datasources                                 1      8m6s
plutono-datasources-seed                            1      96s

/cc @rfranzke

Release note:

An issue causing the `plutono-datasources` ConfigMap to be reconciled by 2 ManagedResources when Seed is Garden managed by `gardener-operator` is now fixed. Occasionally, the issue was preventing successful Seed deletion.

@gardener-prow gardener-prow bot requested a review from rfranzke August 22, 2025 09:00
@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2025
@plkokanov
Copy link
Contributor

plkokanov commented Aug 22, 2025

pull-gardener-e2e-kind-ipv6 failed with:

• [FAILED] [0.654 seconds]
Shoot Tests Create Shoot, Rotate Credentials and Delete Shoot Shoot with workers with workers rollout [It] Create Shoot [Shoot, default, credentials-rotation, basic, with-workers-rollout]
/home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/create_rotate_delete.go:244
   Timeline >>
  > Enter [It] Create Shoot @ 08/22/25 09:16:13.394
  2025-08-22T09:16:13.394Z	INFO	Creating Shoot	{"shoot": {"name":"e2e-rotate","namespace":"garden-local"}}
  [FAILED] in [It] - /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/shoot.go:86 @ 08/22/25 09:16:14.048
  < Exit [It] Create Shoot @ 08/22/25 09:16:14.048 (654ms)
  << Timeline
   [FAILED] Told to stop trying after 0.654s.
  shoot already exists
  At one point, however, the function did return successfully.
  Yet, Eventually failed because the matcher was not satisfied:
  Expected success, but got an error:
      <*errors.StatusError | 0xc0026dd360>: 
      the server is currently unable to handle the request (post shoots.core.gardener.cloud)
      {
          ErrStatus: {
              TypeMeta: {Kind: "", APIVersion: ""},
              ListMeta: {
                  SelfLink: "",
                  ResourceVersion: "",
                  Continue: "",
                  RemainingItemCount: nil,
              },
              Status: "Failure",
              Message: "the server is currently unable to handle the request (post shoots.core.gardener.cloud)",
              Reason: "ServiceUnavailable",
              Details: {
                  Name: "",
                  Group: "core.gardener.cloud",
                  Kind: "shoots",
                  UID: "",
                  Causes: [
                      {
                          Type: "UnexpectedServerResponse",
                          Message: "error trying to reach service: unexpected EOF",
                          Field: "",
                      },
                  ],
                  RetryAfterSeconds: 0,
              },
              Code: 503,
          },
      }
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/shoot.go:86 @ 08/22/25 09:16:14.048

This seems different from #12020

/retest pull-gardener-e2e-kind-ipv6


pull-gardener-e2e-kind failed with

• [FAILED] [13.461 seconds]
Shoot Tests Create, Authenticate, Delete [It] should verify a shoot cannot be accessed with a client certificate from another shoot by manipulating the apiserver-proxy header [Shoot, default, authentication]
/home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/create_authenticate_delete.go:129
   Timeline >>
  > Enter [It] should verify a shoot cannot be accessed with a client certificate from another shoot by manipulating the apiserver-proxy header @ 08/22/25 09:23:47.208
  [FAILED] in [It] - /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/create_authenticate_delete.go:141 @ 08/22/25 09:24:00.669
  < Exit [It] should verify a shoot cannot be accessed with a client certificate from another shoot by manipulating the apiserver-proxy header @ 08/22/25 09:24:00.669 (13.461s)
  << Timeline
   [FAILED] Failed after 13.460s.
  The function passed to Consistently failed at /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/create_authenticate_delete.go:139 with:
  Expected success, but got an error:
      <*retry.Error | 0xc003bccaa0>: 
      retry failed with context deadline exceeded, last error: failed to get server groups: Get "https://kubernetes.default.svc.cluster.local/api": Get "https://kubernetes.default.svc.cluster.local/api": EOF
      {
          ctxError: <context.deadlineExceededError>{},
          err: <*fmt.wrapError | 0xc003bcca80>{
              msg: "failed to get server groups: Get \"https://kubernetes.default.svc.cluster.local/api\": Get \"https://kubernetes.default.svc.cluster.local/api\": EOF",
              err: <*url.Error | 0xc003dc4240>{
                  Op: "Get",
                  URL: "https://kubernetes.default.svc.cluster.local/api",
                  Err: <*url.Error | 0xc003dc4210>{
                      Op: "Get",
                      URL: "https://kubernetes.default.svc.cluster.local/api",
                      Err: <*errors.errorString | 0x50b7c50>{s: "EOF"},
                  },
              },
          },
      }
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/create_authenticate_delete.go:141 @ 08/22/25 09:24:00.669

/retest pull-gardener-e2e-kind

Update: I opened #12795 for this case as I have also seen it in the past.

@gardener gardener deleted a comment from gardener-prow bot Aug 22, 2025
@plkokanov
Copy link
Contributor

/test pull-gardener-e2e-kind-ipv6
/test pull-gardener-e2e-kind

@ialidzhikov
Copy link
Member

@Kostov6 , could you add a release note as we have to cherry-pick this PR?

@Kostov6 Kostov6 force-pushed the bugfix/plutono-datasource-name-collision branch from 7a2a3e4 to b227c44 Compare August 22, 2025 11:05
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 22, 2025
@Kostov6
Copy link
Contributor Author

Kostov6 commented Aug 22, 2025

Note to reviewers:

  • First commit introduces test that passes capturing the behavior prior to the change
  • Second commit introduces the bug fix, test from first commit fails and then it fixes the test

Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com>
@Kostov6 Kostov6 force-pushed the bugfix/plutono-datasource-name-collision branch from 252dacf to 33e75ad Compare August 22, 2025 11:37
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2025
Copy link
Contributor

gardener-prow bot commented Aug 22, 2025

LGTM label has been added.

Git tree hash: 217bd7edb0d1506c773db547ff70856944fe87da

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable, thank you for finding this!
/approve

Copy link
Contributor

gardener-prow bot commented Aug 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2025
@plkokanov
Copy link
Contributor

/cherry-pick release-v1.125

@gardener-ci-robot
Copy link
Contributor

@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v1.125 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@plkokanov
Copy link
Contributor

/cherry-pick release-v1.124

@gardener-ci-robot
Copy link
Contributor

@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v1.124 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@plkokanov
Copy link
Contributor

/cherry-pick release-v1.126

@gardener-ci-robot
Copy link
Contributor

@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v1.126 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.126

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot merged commit 7808ab3 into gardener:master Aug 22, 2025
19 checks passed
@gardener-ci-robot
Copy link
Contributor

@plkokanov: new pull request created: #12796

In response to this:

/cherry-pick release-v1.125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@plkokanov: new pull request created: #12797

In response to this:

/cherry-pick release-v1.124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@plkokanov: new pull request created: #12798

In response to this:

/cherry-pick release-v1.126

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test] Test cleanup after E2E tests is flaky
5 participants