-
Notifications
You must be signed in to change notification settings - Fork 527
Suffix plutono-datasources
configmap name to avoid name collision with operator
#12794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suffix plutono-datasources
configmap name to avoid name collision with operator
#12794
Conversation
pull-gardener-e2e-kind-ipv6 failed with:
This seems different from #12020 /retest pull-gardener-e2e-kind-ipv6 pull-gardener-e2e-kind failed with
/retest pull-gardener-e2e-kind Update: I opened #12795 for this case as I have also seen it in the past. |
/test pull-gardener-e2e-kind-ipv6 |
@Kostov6 , could you add a release note as we have to cherry-pick this PR? |
… by gardener-operator` test scenario
7a2a3e4
to
b227c44
Compare
Note to reviewers:
|
Co-authored-by: Ismail Alidzhikov <9372594+ialidzhikov@users.noreply.github.com>
252dacf
to
33e75ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
/lgtm
LGTM label has been added. Git tree hash: 217bd7edb0d1506c773db547ff70856944fe87da
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable, thank you for finding this!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-v1.125 |
@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v1.125 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-v1.124 |
@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v1.124 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-v1.126 |
@plkokanov: once the present PR merges, I will cherry-pick it on top of release-v1.126 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@plkokanov: new pull request created: #12796 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@plkokanov: new pull request created: #12797 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@plkokanov: new pull request created: #12798 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this PR?
/area quality
/kind bug
What this PR does / why we need it:
Seems to be caused by #12762
This PR suffixes
plutono-datasources
whenOnlyDeployDataSourcesAndDashboards
is set mirroring the behavior of the data fieldgardener/pkg/component/observability/plutono/plutono.go
Line 238 in bdfa23a
Which issue(s) this PR fixes:
Fixes #12785
Special notes for your reviewer:
Result after running local operator setup
/cc @rfranzke
Release note: