Skip to content

ci: Build golang-test images for Go 1.25 #12770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

ci: Build golang-test images for Go 1.25 #12770

merged 1 commit into from
Aug 19, 2025

Conversation

marc1404
Copy link
Member

@marc1404 marc1404 commented Aug 19, 2025 •
edited
Loading

How to categorize this PR?

/area dev-productivity
/kind enhancement

What this PR does / why we need it:

This PR starts building golang-test images for Go 1.25.
Additionally, it stops building them for Go 1.23 because it is out of maintenance.

Which issue(s) this PR fixes:

Preparation for:

Special notes for your reviewer:

/cc @shafeeqes

This PR is based on the same approach taken for Go 1.24:

Release note:

`golang-test` images for Go 1.25 are built now. Those for Go 1.23 are not built anymore because it is out of maintenance.

@gardener-prow gardener-prow bot requested a review from shafeeqes August 19, 2025 14:09
@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 19, 2025
ialidzhikov
ialidzhikov approved these changes Aug 19, 2025
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 19, 2025

LGTM label has been added.

Git tree hash: 0e41a9f545bc74b1d6dec2e26d75ff510af0ad8e

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@marc1404
Copy link
Member Author

marc1404 commented Aug 19, 2025 •
edited
Loading

Component Observability Logging FluentOperator Suite: [It] CRDs should re-create CRD if it is deleted Output

A suite timeout occurred timedout [TIMEDOUT] A suite timeout occurred
In [JustBeforeEach] at: /home/prow/go/src/github.com/gardener/gardener/pkg/component/observability/logging/fluentoperator/crds_test.go:51 @ 08/19/25 14:31:00.067

This is the Progress Report generated when the suite timeout occurred:
  CRDs should re-create CRD if it is deleted Output (Spec Runtime: 2.733s)
    /home/prow/go/src/github.com/gardener/gardener/pkg/component/observability/logging/fluentoperator/crds_test.go:93
    In [JustBeforeEach] (Node Runtime: 439ms)
      /home/prow/go/src/github.com/gardener/gardener/pkg/component/observability/logging/fluentoperator/crds_test.go:51

    Spec Goroutine
    goroutine 676 [chan receive]
      github.com/gardener/gardener/pkg/component/crddeployer.(*crdDeployer).Deploy.Parallel.ParallelN.func2({0x4484bd8, 0x5d437c0})
        /home/prow/go/src/github.com/gardener/gardener/pkg/utils/flow/taskfn.go:130
      github.com/gardener/gardener/pkg/component/crddeployer.(*crdDeployer).Deploy(0xc0016ae540, {0x4484bd8, 0x5d437c0})
        /home/prow/go/src/github.com/gardener/gardener/pkg/component/crddeployer/crd.go:64
    > github.com/gardener/gardener/pkg/component/observability/logging/fluentoperator_test.init.func1.2()
        /home/prow/go/src/github.com/gardener/gardener/pkg/component/observability/logging/fluentoperator/crds_test.go:52
          | 
          | JustBeforeEach(func() {
          > 	Expect(crdDeployer.Deploy(ctx)).ToNot(HaveOccurred(), "fluent operator crds deploy succeeds")
          | })
          | 
      github.com/onsi/ginkgo/v2/internal.extractBodyFunction.func3({0x0?, 0x0?})
        /home/prow/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.24.0/internal/node.go:505
      github.com/onsi/ginkgo/v2/internal.(*Suite).runNode.func3()
        /home/prow/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.24.0/internal/suite.go:895
      github.com/onsi/ginkgo/v2/internal.(*Suite).runNode in goroutine 12
        /home/prow/go/pkg/mod/github.com/onsi/ginkgo/v2@v2.24.0/internal/suite.go:882

/test pull-gardener-unit

@gardener-prow gardener-prow bot merged commit 091438e into gardener:master Aug 19, 2025
19 checks passed
@marc1404 marc1404 deleted the ci/golang-test-1.25 branch August 20, 2025 06:28
This was referenced Aug 21, 2025
Merged
Merged
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
@marc1404 @Duciwuci
ci: Build golang-test images for Go 1.25 (gardener#12770)
a2b4fe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ialidzhikov ialidzhikov ialidzhikov approved these changes

@shafeeqes shafeeqes Awaiting requested review from shafeeqes

Assignees

@ialidzhikov ialidzhikov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@marc1404 @ialidzhikov