Skip to content

Conversation

matthias-horne
Copy link
Contributor

How to categorize this PR?

/area control-plane
/kind bug

What this PR does / why we need it:

A wrong Shoot configuration can cause the provider extension to not be able to create the MachineClasses or MachineDeployments. The errors that are thrown in this case are on the Worker resource, but are not propagated to the Shoot. The Shoot reconciliation is instead waiting for a timeout and then shows the generic worker status machineDeployments has not been updated error. This error does not help find the wrong configuration in the Shoot.

With this fix the errors in the Worker resource should be propagated to the Shoot immediately to help the user find the wrong configuration.

Ideally the provider extensions catch invalid configurations in the validating admission webhook. This fix is still useful in cases where the required validation is missing.

Which issue(s) this PR fixes:
Partially fixes #12611

Special notes for your reviewer:

i also thought about using

if err := health.CheckExtensionObject(obj); err != nil {
    return err
}

but that is waiting until all MachineDeployments are reconciled and the LastOperation succeeded. This is not what is wanted in this status check method, so I'm only checking for errors instead.

Release note:

Errors that occur during `Worker` reconciliation are now also propagated to the `Shoot` status.

@gardener-prow gardener-prow bot added area/control-plane Control plane related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Aug 19, 2025
@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 19, 2025
@matthias-horne matthias-horne force-pushed the fix-worker-error-propagation branch from 074048a to 40624d5 Compare August 19, 2025 14:23
Copy link
Member

@tobschli tobschli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much 😊
/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
Copy link
Contributor

gardener-prow bot commented Aug 19, 2025

LGTM label has been added.

Git tree hash: c2f08b3865ccd5574e00c5e5d7856e75ffd48715

@matthias-horne
Copy link
Contributor Author

/test pull-gardener-e2e-kind-gardenadm

@rfranzke
Copy link
Member

/approve

Copy link
Contributor

gardener-prow bot commented Aug 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 20, 2025
@gardener-prow gardener-prow bot merged commit 42debaf into gardener:master Aug 20, 2025
19 checks passed
@LucaBernstein
Copy link
Member

LucaBernstein commented Aug 21, 2025

/cherry-pick release-v1.125

@gardener-ci-robot
Copy link
Contributor

@LucaBernstein: new pull request created: #12789

In response to this:

/cherry-pick release-v1.125 release-v1.124 release-v1.123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LucaBernstein
Copy link
Member

LucaBernstein commented Aug 21, 2025

/cherry-pick release-v1.124

@gardener-ci-robot
Copy link
Contributor

@LucaBernstein: new pull request created: #12790

In response to this:

/cherry-pick release-v1.124
/cherry-pick release-v1.123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@LucaBernstein
Copy link
Member

/cherry-pick release-v1.123

@gardener-ci-robot
Copy link
Contributor

@LucaBernstein: new pull request created: #12791

In response to this:

/cherry-pick release-v1.123

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in DeployMachineClasses deadlocks Shoot create/delete
5 participants