-
Notifications
You must be signed in to change notification settings - Fork 526
fix: Propagate error in Worker reconciliation #12769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Propagate error in Worker reconciliation #12769
Conversation
074048a
to
40624d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much 😊
/lgtm
LGTM label has been added. Git tree hash: c2f08b3865ccd5574e00c5e5d7856e75ffd48715
|
/test pull-gardener-e2e-kind-gardenadm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-v1.125 |
@LucaBernstein: new pull request created: #12789 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-v1.124 |
@LucaBernstein: new pull request created: #12790 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-v1.123 |
@LucaBernstein: new pull request created: #12791 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this PR?
/area control-plane
/kind bug
What this PR does / why we need it:
A wrong
Shoot
configuration can cause the provider extension to not be able to create theMachineClasses
orMachineDeployments
. The errors that are thrown in this case are on theWorker
resource, but are not propagated to theShoot
. TheShoot
reconciliation is instead waiting for a timeout and then shows the genericworker status machineDeployments has not been updated
error. This error does not help find the wrong configuration in theShoot
.With this fix the errors in the
Worker
resource should be propagated to theShoot
immediately to help the user find the wrong configuration.Ideally the provider extensions catch invalid configurations in the validating admission webhook. This fix is still useful in cases where the required validation is missing.
Which issue(s) this PR fixes:
Partially fixes #12611
Special notes for your reviewer:
i also thought about using
but that is waiting until all
MachineDeployments
are reconciled and theLastOperation
succeeded. This is not what is wanted in this status check method, so I'm only checking for errors instead.Release note: