Skip to content

Disable plutono-datasources ConfigMap garbage collection #12762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2025
Merged

Disable plutono-datasources ConfigMap garbage collection #12762

merged 1 commit into from
Aug 18, 2025

Conversation

timebertt
Copy link
Member

How to categorize this PR?

/area monitoring
/kind bug

What this PR does / why we need it:

Follow-up to #12476:
Stop marking plutono-datasources as unique to stop the wrongful garbage collection.

Which issue(s) this PR fixes:
Fixes #12760

Special notes for your reviewer:

/cc @rfranzke

After this PR, the old and unused (immutable) ConfigMap will eventually be garbage collected for one last time – so that this PR doesn't require any migration code.

Release note:

The `plutono-datasources` `ConfigMap` is no longer wrongfully garbage collected while it is in use.

@gardener-prow gardener-prow bot requested a review from rfranzke August 18, 2025 15:37
@gardener-prow gardener-prow bot added area/monitoring Monitoring (including availability monitoring and alerting) related kind/bug Bug cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 18, 2025
@timebertt
Copy link
Member Author

/cherry-pick release-v1.125

@timebertt
Copy link
Member Author

/cherry-pick release-v1.124

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.125 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot
Copy link
Contributor

@timebertt: once the present PR merges, I will cherry-pick it on top of release-v1.124 in a new PR and assign it to you.

In response to this:

/cherry-pick release-v1.124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rfranzke
rfranzke reviewed Aug 18, 2025
View reviewed changes
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)
/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 18, 2025

LGTM label has been added.

Git tree hash: d69b5dcc25f3ac7b23e06580de7516e400f72255

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@gardener-prow gardener-prow bot merged commit dae307e into gardener:master Aug 18, 2025
19 checks passed
@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #12765

In response to this:

/cherry-pick release-v1.125

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Aug 18, 2025
Merged
@gardener-ci-robot
Copy link
Contributor

@timebertt: new pull request created: #12766

In response to this:

/cherry-pick release-v1.124

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-ci-robot gardener-ci-robot mentioned this pull request Aug 18, 2025
Merged
@timebertt timebertt deleted the plutono-datasources branch August 18, 2025 18:32
This was referenced Aug 22, 2025
Closed
Merged
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
@timebertt @Duciwuci
Disable plutono-datasources ConfigMap garbage collection (gardener#12762
73af657 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rfranzke rfranzke rfranzke left review comments

Assignees

@rfranzke rfranzke

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/monitoring Monitoring (including availability monitoring and alerting) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

plutono-datasources ConfigMap is garbage collected although it is in use
3 participants
@timebertt @gardener-ci-robot @rfranzke