Skip to content

Add check to disable device-taint-eviction-controller for workerless Shoots with versions >= 1.33 #12757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 19, 2025
Merged

Add check to disable device-taint-eviction-controller for workerless Shoots with versions >= 1.33 #12757

merged 4 commits into from
Aug 19, 2025

Conversation

RadaBDimitrova
Copy link
Contributor

@RadaBDimitrova RadaBDimitrova commented Aug 18, 2025 •
edited by ialidzhikov
Loading

How to categorize this PR?

/area quality
/kind enhancement

What this PR does / why we need it:
After a discussion in the PR introducing support for Kubernetes v1.33, with @plkokanov, @Kostov6 and @ialidzhikov we noticed that the controller manager doesn't have versioned checks for controllers that should be disabled for workerless Shoots.
In the context of the introduction of 1.33, device-taint-eviction-controller seems to be unnecessary for workerless Shoots, but we decided to add this logic in a separate PR.

This PR adds a version check to disable device-taint-eviction-controller when using Kubernetes versions >= 1.33 for workerless Shoots.

Which issue(s) this PR fixes:
Related to #12216

Special notes for your reviewer:
cc @ialidzhikov @plkokanov

Release note:

The `device-taint-eviction-controller` is disabled for workerless Shoots with Kubernetes v1.33+.

@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension labels Aug 18, 2025
@gardener-prow gardener-prow bot added the cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. label Aug 18, 2025
@gardener-prow gardener-prow bot requested a review from LucaBernstein August 18, 2025 12:04
@gardener-prow gardener-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 18, 2025
@gardener-prow gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 18, 2025
@ialidzhikov
Copy link
Member

/assign

@plkokanov
Copy link
Contributor

/assign

marc1404
marc1404 reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Two minor comments, but nothing blocking from my side :) Thanks for following up after the Kubernetes v1.33 update!

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 19, 2025

LGTM label has been added.

Git tree hash: 27bbb5383afe8ffd78f356848999f324132b4883

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@gardener-prow gardener-prow bot requested review from marc1404 and plkokanov August 19, 2025 08:29
ialidzhikov
ialidzhikov reviewed Aug 19, 2025
View reviewed changes
ialidzhikov
ialidzhikov reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@ialidzhikov ialidzhikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2025
@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 19, 2025

LGTM label has been added.

Git tree hash: 021f5137f1db14a500d68942327c2baa63af5fea

marc1404
marc1404 reviewed Aug 19, 2025
View reviewed changes
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Nicely done :)

@plkokanov
Copy link
Contributor

/test pull-gardener-e2e-kind-ha-multi-node

The failure was due to

• [FAILED] [1.720 seconds]
Shoot Tests Create Shoot, Rotate Credentials and Delete Shoot Shoot with workers without workers rollout [It] Verify after prepared for *rotation.ObservabilityVerifier [Shoot, default, credentials-rotation, basic, without-workers-rollout]
/home/prow/go/src/github.com/gardener/gardener/test/e2e/gardener/shoot/create_rotate_delete.go:232
   Timeline >>
  > Enter [It] Verify after prepared for *rotation.ObservabilityVerifier @ 08/19/25 10:21:47.995
  STEP: Use old credentials to access observability endpoint @ 08/19/25 10:21:47.995
  [FAILED] in [It] - /home/prow/go/src/github.com/gardener/gardener/test/utils/rotation/observability.go:76 @ 08/19/25 10:21:49.715
  < Exit [It] Verify after prepared for *rotation.ObservabilityVerifier @ 08/19/25 10:21:49.715 (1.72s)
  << Timeline
   [FAILED] Failed after 1.713s.
  The function passed to Consistently failed at /home/prow/go/src/github.com/gardener/gardener/test/utils/rotation/observability.go:74 with:
  Unexpected error:
      <*url.Error | 0xc003a623c0>: 
      Get "[https://gu-local--e2e-rot-noroll.ingress.local.seed.local.gardener.cloud:443](https://gu-local--e2e-rot-noroll.ingress.local.seed.local.gardener.cloud/)": dial tcp 172.18.255.1:443: connect: connection refused
      {
          Op: "Get",
          URL: "[https://gu-local--e2e-rot-noroll.ingress.local.seed.local.gardener.cloud:443](https://gu-local--e2e-rot-noroll.ingress.local.seed.local.gardener.cloud/)",
          Err: <*net.OpError | 0xc00399b4a0>{
              Op: "dial",
              Net: "tcp",
              Source: nil,
              Addr: <*net.TCPAddr | 0xc003a62390>{
                  IP: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 255, 255, 172, 18, 255, 1],
                  Port: 443,
                  Zone: "",
              },
              Err: <*os.SyscallError | 0xc0030dfe80>{
                  Syscall: "connect",
                  Err: <syscall.Errno>0x6f,
              },
          },
      }
  occurred
  In [It] at: /home/prow/go/src/github.com/gardener/gardener/test/utils/rotation/observability.go:76 @ 08/19/25 10:21:49.715

plkokanov
plkokanov reviewed Aug 19, 2025
View reviewed changes
Copy link
Contributor

@plkokanov plkokanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for applying the logic :)

/lgtm
/approve

@gardener-prow Gardener Prow
Copy link
Contributor

gardener-prow bot commented Aug 19, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: plkokanov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 19, 2025
@gardener-prow gardener-prow bot merged commit 05f480c into gardener:master Aug 19, 2025
19 checks passed
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
@RadaBDimitrova @Duciwuci
Add check to disable device-taint-eviction-controller for workerles…
0c35d18 
…s Shoots with versions >= 1.33 (gardener#12757)

* Add version check to disable device-taint-eviction-controller after 1.33

* Add test case and adapt tests to cover versioned disabled controllers

* Address PR review feedback nits

* Address PR review feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marc1404 marc1404 marc1404 left review comments

@ialidzhikov ialidzhikov ialidzhikov left review comments

@plkokanov plkokanov plkokanov left review comments

@dimitar-kostadinov dimitar-kostadinov Awaiting requested review from dimitar-kostadinov

@LucaBernstein LucaBernstein Awaiting requested review from LucaBernstein

Assignees

@marc1404 marc1404

@ialidzhikov ialidzhikov

@plkokanov plkokanov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RadaBDimitrova @ialidzhikov @plkokanov @marc1404