Enhance collected shoot apiserver metrics #12716
Conversation
Collect apiserver_validating_admission_policy_check_total by shoot Prometheus to allow shoot owners to monitor their admission policies.
|
LGTM label has been added. Git tree hash: 96351aa0e67e14ec26b5e87757472cf97e3ebab4
|
|
/assign @tobschli |
There was a problem hiding this comment.
Thank you very much! 😊
In the docs there is als apiserver_validating_admission_policy_check_duration_seconds_bucket mentioned.
When I tried out this PR, I could not see this metric.
Do we collect it? Do we want to collect it?
Otherwise I don't see anything not to merge this
/lgtm
The main purpose of this PR is to allow shoot owners to federate the whitelisted metric to their own monitoring stack. As long as we do not visualize this in our dashboards, I would not collect a (possibly large) histogram metric and keep this change minimal. |
|
All right! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: istvanballok, tobschli The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Collect apiserver_validating_admission_policy_check_total by shoot Prometheus to allow shoot owners to monitor their admission policies.
How to categorize this PR?
/area monitoring
/kind enhancement
What this PR does / why we need it:
Collect apiserver_validating_admission_policy_check_total by shoot Prometheus to allow shoot owners to monitor their admission policies.
The metric is recommended to monitor the Validating Admission Policy, which has been graduated to GA with Kubernetes 1.30. See https://kubernetes.io/blog/2024/04/24/validating-admission-policy-ga/#set-up-monitoring
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/cc @istvanballok @vicwicker
Release note: