Introduce Seed annotation to temporarily disable Shoot reconciliations
#12712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- gardenlet Shoot controller's ShouldReconcileNow is added a reason to log - shoot.status.lastOperation is filled with Pending state so that further annotations to the Shoot after the annotation has been removed lead to a generation increase and thus a reconciliation. See: https://github.com/gardener/gardener/blob/874791cb97e96d622c994c6cc8ef4091fc9e9102/pkg/apiserver/registry/core/shoot/strategy.go#L101 Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
… status - Extract `HasShootReconciliationsDisabledAnnotation` fn Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
…oot` reconciliation Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
|
/assign |
ScheererJ
reviewed
Aug 12, 2025
rfranzke
reviewed
Aug 12, 2025
- improve docs - improve var and const namings - condense seed health check regarding emergency annotation - add test cases Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
rfranzke
reviewed
Aug 13, 2025
|
LGTM label has been added. Git tree hash: 68c2d9d534b2940b704c53d59e4e14ec043e7736
|
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
4a76da0 to
8e534a0
Compare
|
LGTM label has been added. Git tree hash: c8829a51daa3b339c045e60117b60b07ca351da1
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke, ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
…tions (gardener#12712) * Add `Seed` annotation to temporarily disable `Shoot` reconciliations - gardenlet Shoot controller's ShouldReconcileNow is added a reason to log - shoot.status.lastOperation is filled with Pending state so that further annotations to the Shoot after the annotation has been removed lead to a generation increase and thus a reconciliation. See: https://github.com/gardener/gardener/blob/874791cb97e96d622c994c6cc8ef4091fc9e9102/pkg/apiserver/registry/core/shoot/strategy.go#L101 Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Expose condition about disabled `Shoot` reconciliations in the `Seed` status - Extract `HasShootReconciliationsDisabledAnnotation` fn Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Do not schedule new `Shoot`s to `Seeds` with temporarily disabled `Shoot` reconciliation Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Add documentation about the annotation for seed operations Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Address review feedback - improve docs - improve var and const namings - condense seed health check regarding emergency annotation - add test cases Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Address review feedback (2) Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> --------- Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ops-productivity robustness
/kind enhancement
What this PR does / why we need it:
There may be situations where you need to temporarily stop the reconciliation of
Shootclusters in aSeedcluster.This can be achieved by adding the annotation
gardener.cloud/disable-shoot-reconciliations=trueto theSeedresource.While this annotation is present:
Seedcontroller will not reconcile anyShootclusters in the affectedSeed.Shootclusters will not be scheduled to thisSeed.Seedwill expose theSeedDisabledShootReconciliationscondition.Which issue(s) this PR fixes:
Fixes #12528
Special notes for your reviewer:
/cc @rfranzke @ScheererJ
Release note: