-
Notifications
You must be signed in to change notification settings - Fork 526
Update Setup Guide to include Cert Management for Garden #12706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/assign |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 87de0d83be93588bd0bdecf3ef3f4a8a0a7f1764
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for improving the setup guide! I prefer explaining the extensions earlier, and covering the usage of the certificate extension is a great addition 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 822ce0c01a3b1a3d0d111413d419036d1825be35
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marc1404 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
) * Update Setup Guide to include Cert Management for Garden * Update docs/deployment/setup_gardener.md * Update docs/deployment/setup_gardener.md * Update docs/deployment/setup_gardener.md * Update docs/deployment/setup_gardener.md * Update docs/deployment/setup_gardener.md * Update docs/deployment/setup_gardener.md * Update docs/deployment/setup_gardener.md --------- Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>
How to categorize this PR?
/area documentation
/kind enhancement
What this PR does / why we need it:
Expand the setup guide to explain the usage of the cert-management extension for managing the
garden
certificates.I also changed the order to explain the
Extension
resource before referring to it in theGarden
section.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
/invite @marc1404 @tobschli
Release note: