Skip to content

Conversation

hendrikKahl
Copy link
Contributor

How to categorize this PR?

/area documentation
/kind enhancement

What this PR does / why we need it:

Expand the setup guide to explain the usage of the cert-management extension for managing the garden certificates.

I also changed the order to explain the Extension resource before referring to it in the Garden section.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

/invite @marc1404 @tobschli

Release note:

Update Setup Guide to include Cert Management for Garden

@gardener-prow gardener-prow bot added area/documentation Documentation related kind/enhancement Enhancement, improvement, extension labels Aug 11, 2025
@gardener-prow gardener-prow bot requested review from Kostov6 and timebertt August 11, 2025 13:30
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 11, 2025
@marc1404
Copy link
Member

/assign

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
Copy link
Contributor

gardener-prow bot commented Aug 12, 2025

LGTM label has been added.

Git tree hash: 87de0d83be93588bd0bdecf3ef3f4a8a0a7f1764

Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the setup guide! I prefer explaining the extensions earlier, and covering the usage of the certificate extension is a great addition 👏

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
@gardener-prow gardener-prow bot requested review from marc1404 and rfranzke August 13, 2025 15:17
Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2025
Copy link
Contributor

gardener-prow bot commented Aug 13, 2025

LGTM label has been added.

Git tree hash: 822ce0c01a3b1a3d0d111413d419036d1825be35

Copy link
Contributor

gardener-prow bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@hendrikKahl
Copy link
Contributor Author

/retest

@gardener-prow gardener-prow bot merged commit 41d5e6c into gardener:master Aug 14, 2025
18 checks passed
@hendrikKahl hendrikKahl deleted the docs/setup-update branch August 14, 2025 08:56
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
)

* Update Setup Guide to include Cert Management for Garden

* Update docs/deployment/setup_gardener.md

* Update docs/deployment/setup_gardener.md

* Update docs/deployment/setup_gardener.md

* Update docs/deployment/setup_gardener.md

* Update docs/deployment/setup_gardener.md

* Update docs/deployment/setup_gardener.md

* Update docs/deployment/setup_gardener.md

---------

Co-authored-by: Marc Vornetran <marc1404@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Documentation related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants