-
Notifications
You must be signed in to change notification settings - Fork 526
Clean up obsolete CI scripts #12705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up obsolete CI scripts #12705
Conversation
The `.ci/set_dependency_version` script is part of the [component upgrade contract](https://gardener.github.io/cc-utils/traits/update_component_deps.html). However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images. The `hack/.ci/set_dependency_version` script is still preserved as it is still reused by the extension repositories. See also the [ocm-upgrade action](https://github.com/gardener/cc-utils/blob/master/.github/actions/ocm-upgrade/action.yaml).
The script does not seem to be used after gardener#12592.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 34c855f82afc57ceb4f5235f19db1b49a5d6a659
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Thanks for cleaning up! 🧹 ✨
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ccwienk, marc1404 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Clean up the obsolete `.ci/set_dependency_version` script The `.ci/set_dependency_version` script is part of the [component upgrade contract](https://gardener.github.io/cc-utils/traits/update_component_deps.html). However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images. The `hack/.ci/set_dependency_version` script is still preserved as it is still reused by the extension repositories. See also the [ocm-upgrade action](https://github.com/gardener/cc-utils/blob/master/.github/actions/ocm-upgrade/action.yaml). * Clean up the obsolete `.ci/verify` script The script does not seem to be used after gardener#12592.
How to categorize this PR?
/area delivery
/kind cleanup
What this PR does / why we need it:
1st commit:
The
.ci/set_dependency_version
script is part of the component upgrade contract.However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images.
The
hack/.ci/set_dependency_version
script is still preserved as it is still reused by the extension repositories. See also the ocm-upgrade action.2nd commit:
The
.ci/verify
script does not seem to be used after migrate CICD-Pipeline to GitHub-Actions #12592.Which issue(s) this PR fixes:
Follow-up after #12592
Special notes for your reviewer:
N/A
Release note: