Skip to content

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented Aug 11, 2025

How to categorize this PR?

/area delivery
/kind cleanup

What this PR does / why we need it:

  1. 1st commit:
    The .ci/set_dependency_version script is part of the component upgrade contract.
    However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images.

    The hack/.ci/set_dependency_version script is still preserved as it is still reused by the extension repositories. See also the ocm-upgrade action.

  2. 2nd commit:
    The .ci/verify script does not seem to be used after migrate CICD-Pipeline to GitHub-Actions #12592.

Which issue(s) this PR fixes:
Follow-up after #12592

Special notes for your reviewer:
N/A

Release note:

NONE

The `.ci/set_dependency_version` script is part of the [component upgrade contract](https://gardener.github.io/cc-utils/traits/update_component_deps.html).
However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images.

The `hack/.ci/set_dependency_version` script is still preserved as it is still reused by the extension repositories. See also the [ocm-upgrade action](https://github.com/gardener/cc-utils/blob/master/.github/actions/ocm-upgrade/action.yaml).
The script does not seem to be used after gardener#12592.
@gardener-prow gardener-prow bot added area/delivery Delivery related kind/cleanup Something that is not needed anymore and can be cleaned up cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Aug 11, 2025
@gardener-prow gardener-prow bot requested review from Kostov6 and plkokanov August 11, 2025 13:01
@ialidzhikov
Copy link
Member Author

@gardener-prow gardener-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 11, 2025
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
Copy link
Contributor

gardener-prow bot commented Aug 12, 2025

LGTM label has been added.

Git tree hash: 34c855f82afc57ceb4f5235f19db1b49a5d6a659

@rfranzke
Copy link
Member

/lgtm

Copy link
Member

@marc1404 marc1404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for cleaning up! 🧹 ✨

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2025
@gardener-prow gardener-prow bot merged commit eb6946c into gardener:master Aug 13, 2025
19 checks passed
Copy link
Contributor

gardener-prow bot commented Aug 13, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ccwienk, marc1404

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ialidzhikov ialidzhikov deleted the cleanup/obsolete-ci-scripts branch August 14, 2025 06:59
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
* Clean up the obsolete `.ci/set_dependency_version` script

The `.ci/set_dependency_version` script is part of the [component upgrade contract](https://gardener.github.io/cc-utils/traits/update_component_deps.html).
However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images.

The `hack/.ci/set_dependency_version` script is still preserved as it is still reused by the extension repositories. See also the [ocm-upgrade action](https://github.com/gardener/cc-utils/blob/master/.github/actions/ocm-upgrade/action.yaml).

* Clean up the obsolete `.ci/verify` script

The script does not seem to be used after gardener#12592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants