Skip to content

Conversation

axel7born
Copy link
Contributor

@axel7born axel7born commented Aug 6, 2025

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
With change #12470, we updated the constraint for ongoing dual-stack migration from 'false' to 'progressing'. Unfortunately, we overlooked one instance.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

The status of constraint  `DualStackNodesMigrationReady`  is now `progressing` instead of `false` at the start of a migration to dual-stack networking.

by using ConditionProgressing
@gardener-prow gardener-prow bot added area/networking Networking related kind/bug Bug labels Aug 6, 2025
@gardener-prow gardener-prow bot requested review from timebertt and vitanovs August 6, 2025 12:12
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 6, 2025
Copy link
Member

@ScheererJ ScheererJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Thanks for following up on the dual-stack migration.

What does this mean for the dual-stack migration without this change? Does it need to be backported to older releases?

/cc @tobschli

/lgtm
/approve

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2025
@gardener-prow gardener-prow bot requested a review from tobschli August 6, 2025 12:20
Copy link
Contributor

gardener-prow bot commented Aug 6, 2025

LGTM label has been added.

Git tree hash: 0517aae585523f1220e8523cb19df0fd4836f995

Copy link
Contributor

gardener-prow bot commented Aug 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ScheererJ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2025
@gardener-prow gardener-prow bot merged commit 0508f35 into gardener:master Aug 6, 2025
19 checks passed
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/bug Bug lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants