Configure vpa-updater with a ServiceMonitor to allow metrics scraping
#12677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
14c697a to
0e58eae
Compare
|
/assign |
Kostov6
reviewed
Aug 6, 2025
This commit introduces a ServiceMonitor resource to the VPA updater in order to scrape the component metrics by Prometheus. Also: - As a requirement, a new Service resource is created to enable the ServiceMonitor referrence with the VPA updater.
… expected resources This commit adds the new vpa-updater ServiceMonitor and Service to the expected resources within the vpa unit tests.
0e58eae to
5783f15
Compare
…rent cluster types This commit instruments the utility functions that create testing resources to use switch and separate the different cluster types in dedicated cases.
4eb51ea to
a35364d
Compare
|
LGTM label has been added. Git tree hash: 7e3c460272722724a892aa82c95c565fe4784414
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: plkokanov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
…ping (gardener#12677) * feat(vpa/updater): add `ServiceMonitor` to `vpa-updater` This commit introduces a ServiceMonitor resource to the VPA updater in order to scrape the component metrics by Prometheus. Also: - As a requirement, a new Service resource is created to enable the ServiceMonitor referrence with the VPA updater. * feat(vpa/updater/test): include `ServiceMonitor` and `Service` to the expected resources This commit adds the new vpa-updater ServiceMonitor and Service to the expected resources within the vpa unit tests. * feat(vpa/updater/test): add tests to check if `ServiceMonitor` is labeled correctly * chore(vpa/updater/test): use `switch` when creating objects for different cluster types This commit instruments the utility functions that create testing resources to use switch and separate the different cluster types in dedicated cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/kind enhancement
What this PR does / why we need it:
This PR introduces an additional
ServiceMonitorandServicerecords for thevpa-updater, allowing the Prometheus operator deployment to scrape the component [vpa-updater] metrics.Following the local setup guide, the following metric entries should be available:
Which issue(s) this PR fixes:
Fixes #12676
Release note: