Harden (Namespaced)CloudProfile field validation
#12666
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
marc1404
reviewed
Aug 5, 2025
| Expect(validationResult).To(BeEmpty()) | ||
| } | ||
| }, | ||
| Entry("forbid emoji characters", "🪴", true), |
|
LGTM label has been added. Git tree hash: bd0a45a18039cfa0325570c98aac93c9d0571027
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
* Validate MachineImage name Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Extract fn validateUnprefixedQualifiedName Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Validate container runtime types Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Fix value in error message * Validate names and values of capabilities Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Validate machineType name * Validate volumeType name Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Validate volumeType class Signed-off-by: Luca Bernstein <luca.bernstein@sap.com> * Satisfy typo linter --------- Signed-off-by: Luca Bernstein <luca.bernstein@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area robustness security usability
/kind enhancement
What this PR does / why we need it:
Add more strict validation to multiple fields in the (Namespaced)CloudProfile specs.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: