-
Notifications
You must be signed in to change notification settings - Fork 526
Use v1 version of the API resource AdmissionConfiguration
#12615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use v1 version of the API resource AdmissionConfiguration
#12615
Conversation
/assign @dimityrmirchev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: a44221fd203b7e6dc6d2f5db9285c53a983fbce2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care :)
aad0035
to
c1a10fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for removing the obsolete v1alpha1
version! Thank you @acumino for noticing!
/lgtm
LGTM label has been added. Git tree hash: 19a831ded253100af5417530dd835602d5b35d83
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino, dimityrmirchev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…#12615) * Migrate AdmissionConfiguration from API version v1alpha1 to v1 * Remove apiGroup v1alpha1 from the admissionScheme of the admission controller
How to categorize this PR?
/area quality
/kind enhancement
What this PR does / why we need it:
This PR migrates the
AdmissionConfiguration
resource of theapiserver.k8s.io
API from versionv1alpha1
tov1
.The
v1alpha1
version of the resource has been deprecated since k8s 1.17.Which issue(s) this PR fixes:
Fixes #12415
Special notes for your reviewer:
Release note: