Skip to content

Conversation

georgibaltiev
Copy link
Contributor

How to categorize this PR?

/area quality
/kind enhancement

What this PR does / why we need it:
This PR migrates the AdmissionConfiguration resource of the apiserver.k8s.io API from version v1alpha1 to v1.
The v1alpha1 version of the resource has been deprecated since k8s 1.17.

Which issue(s) this PR fixes:
Fixes #12415

Special notes for your reviewer:

Release note:

The AdmissionConfiguration API resource has been migrated from version v1alpha1 to v1.

@gardener-prow gardener-prow bot added area/quality Output qualification (tests, checks, scans, automation in general, etc.) related kind/enhancement Enhancement, improvement, extension cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 28, 2025
@gardener-prow gardener-prow bot requested review from timebertt and vitanovs July 28, 2025 12:27
@ialidzhikov
Copy link
Member

/assign @dimityrmirchev

Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 28, 2025
Copy link
Contributor

gardener-prow bot commented Jul 28, 2025

LGTM label has been added.

Git tree hash: a44221fd203b7e6dc6d2f5db9285c53a983fbce2

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care :)

@georgibaltiev georgibaltiev force-pushed the update-admission-configuration-api-version branch from aad0035 to c1a10fc Compare August 15, 2025 12:40
@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2025
@gardener-prow gardener-prow bot requested a review from dimityrmirchev August 15, 2025 12:40
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing the obsolete v1alpha1 version! Thank you @acumino for noticing!

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 18, 2025
Copy link
Contributor

gardener-prow bot commented Aug 18, 2025

LGTM label has been added.

Git tree hash: 19a831ded253100af5417530dd835602d5b35d83

Copy link
Member

@acumino acumino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

Copy link
Contributor

gardener-prow bot commented Aug 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: acumino, dimityrmirchev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2025
@gardener-prow gardener-prow bot merged commit 4d4d2c5 into gardener:master Aug 18, 2025
19 checks passed
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
…#12615)

* Migrate AdmissionConfiguration from API version v1alpha1 to v1

* Remove apiGroup v1alpha1 from the admissionScheme of the admission controller
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/quality Output qualification (tests, checks, scans, automation in general, etc.) related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use v1 API of apiserver AdmissionConfiguration
5 participants