Skip to content

Conversation

ccwienk
Copy link
Member

@ccwienk ccwienk commented Jul 22, 2025

see: https://gardener.github.io/cc-utils/github_actions.html

How to categorize this PR?

/area delivery
/kind technical-debt
/kind task

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

As GitHub-Action will only become available after merging this pullrequest, please refer to, e.g. this run for checking on the pipeline.

Release note:

migrate CICD-Pipeline to GitHub-Actions

@gardener-prow gardener-prow bot added area/delivery Delivery related kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly kind/task General task cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. labels Jul 22, 2025
@gardener-prow gardener-prow bot requested review from acumino and rfranzke July 22, 2025 20:12
@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 22, 2025
@ccwienk ccwienk force-pushed the master branch 3 times, most recently from 4df8de2 to 2ea1476 Compare July 23, 2025 05:06
@ccwienk

This comment was marked as outdated.

@ccwienk

This comment was marked as outdated.

@rfranzke
Copy link
Member

/assign @oliver-goetz

@LucaBernstein
Copy link
Member

/cc @tobschli
as next release responsible.
We should probably wait until this week's release has been cut.
/hold

@gardener-prow gardener-prow bot requested a review from tobschli July 23, 2025 06:04
@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 23, 2025
@ccwienk
Copy link
Member Author

ccwienk commented Jul 23, 2025

/cc @tobias Schlicht as next release responsible. We should probably wait until this week's release has been cut. /hold

@LucaBernstein : in the end, that's of course up to you. The underlying workflows have already been used for some releases in the past (e.g. for dashboard, and also some extensions). I do not think waiting for one more release will make a lot of a difference; if you like, I could drop the deletion of .ci/pipeline_definitions and .ci/component_descriptor, respectively. In that case, accepting this pullrequest will give you the option to use either concourse or GitHub-Actions for creating a release (so you might fallback to Concourse, if there should be any issues).

Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, just one more question from my side @ccwienk 😃

mode: release

release-to-github-and-bump:
uses: gardener/cc-utils/.github/workflows/release.yaml@master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you cut releases in cc-utils or should we pin the references to some tag/hash to ensure reproducability and controlled updates?

Copy link
Member Author

@ccwienk ccwienk Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently (as there is still some ongoing development), there is not yet a branching-model in place. For the time being, it might be considered to pin to commit-digests after release (such as to fixate release-branches), and remain on master for gardener/gardener's master-branch.

I will (have to) think of a proper release process, also considering usage for gh-tools/wdf; however, this is out-of scope for initial migration. Also, this is equivalent to concourse-pipelines, where - while there is a QA-step involved - there is also only ever one global pipeline-template-version 🫣

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that I think of it, we could even include the commit-pinning into the release.yaml-workflow so that this will be done automatically upon release, as part of the release-commit. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's some ideas there, thanks for thinking about it.
Maybe later we will introduce versioning in the cc-utils once it's considered stable(r).
We could go with the as-is for now imho. Maybe, as you suggested, we could eventually pin the utils commit upon release.

@ccwienk

This comment was marked as outdated.

@ccwienk

This comment was marked as resolved.

@ccwienk

This comment was marked as outdated.

@ccwienk
Copy link
Member Author

ccwienk commented Jul 24, 2025

/hold - need to add relase-assets

/unhold (done)

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2025
@ccwienk
Copy link
Member Author

ccwienk commented Jul 24, 2025

however:
/hold (so @LucaBernstein 's hold is not undone)

Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for moving the repo to github actions 🚀

@gardener-prow gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2025
@ccwienk ccwienk force-pushed the master branch 4 times, most recently from 14cec34 to a948e77 Compare July 29, 2025 06:00
Copy link
Member

@LucaBernstein LucaBernstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2025
Copy link
Contributor

gardener-prow bot commented Jul 29, 2025

LGTM label has been added.

Git tree hash: 11e03491c1bf5252fe1755c02df186ee82a9c806

Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, let's go 🤞
😄

/approve
/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2025
Copy link
Contributor

gardener-prow bot commented Jul 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2025
@oliver-goetz oliver-goetz merged commit a13c79f into gardener:master Jul 29, 2025
19 checks passed
@oliver-goetz
Copy link
Member

I had to merge the PR manually, because it is updating Github workflows.

@ialidzhikov
Copy link
Member

The workflow is not valid. In .github/workflows/non-release.yaml (Line: 8, Col: 11): Error from called workflow gardener/gardener/.github/workflows/build.yaml@a13c79fc998fafaa135083122d82b590f4723eb9 (Line: 176, Col: 9): Job 'gardenadm' depends on unknown job 'test'.

ialidzhikov added a commit to ialidzhikov/gardener that referenced this pull request Aug 11, 2025
The script does not seem to be used after gardener#12592.
gardener-prow bot pushed a commit that referenced this pull request Aug 13, 2025
* Clean up the obsolete `.ci/set_dependency_version` script

The `.ci/set_dependency_version` script is part of the [component upgrade contract](https://gardener.github.io/cc-utils/traits/update_component_deps.html).
However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images.

The `hack/.ci/set_dependency_version` script is still preserved as it is still reused by the extension repositories. See also the [ocm-upgrade action](https://github.com/gardener/cc-utils/blob/master/.github/actions/ocm-upgrade/action.yaml).

* Clean up the obsolete `.ci/verify` script

The script does not seem to be used after #12592.
Duciwuci pushed a commit to stackitcloud/gardener that referenced this pull request Sep 1, 2025
* Clean up the obsolete `.ci/set_dependency_version` script

The `.ci/set_dependency_version` script is part of the [component upgrade contract](https://gardener.github.io/cc-utils/traits/update_component_deps.html).
However, the gardener/gardener repository no longer uses concourse. Even before than, I am not sure if this component upgrade contract was used for the gardener/gardener repo after the introduction of Renovate for updating referenced OCI images.

The `hack/.ci/set_dependency_version` script is still preserved as it is still reused by the extension repositories. See also the [ocm-upgrade action](https://github.com/gardener/cc-utils/blob/master/.github/actions/ocm-upgrade/action.yaml).

* Clean up the obsolete `.ci/verify` script

The script does not seem to be used after gardener#12592.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/delivery Delivery related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/task General task kind/technical-debt Something that is only solved on the surface, but requires more (re)work to be done properly lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants