Prevent gardener-node-agent entering crash-loop on breaking changes to config
#12589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19a11e5 to
7602bd1
Compare
Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com>
Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com>
Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com>
7602bd1 to
273303a
Compare
|
/assign |
Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Aleksandar Savchev <aleksandar.savchev@sap.com>
|
/retest |
|
LGTM label has been added. Git tree hash: e174f7508aa8538ff97bfdba1a83d6ebdf6fcbdc
|
oliver-goetz
approved these changes
Jul 31, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliver-goetz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Very nice! |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
… to config (gardener#12589) * Add helper funcs to generate node-agent config path Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com> * Replace config path with config dir in gardener-node-agent Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com> * Adapt GetAPIServerConfig() func to work with non default directories Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com> * Run ./hack/update-skaffold-deps.sh * Adapt integration tests Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Aleksandar Savchev <aleksandar.savchev@sap.com> * Fix linter issue --------- Co-authored-by: Oliver Goetz <o.goetz@sap.com> Co-authored-by: Rada Dimitrova <rada.dimitrova@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area robustness
/kind bug
What this PR does / why we need it:
This PR fixes an issue with
gardener-node-agentwhich was causing it to enter crash-loop when a breaking change on its config was introduced and the pull of the newgardener-node-agentimage failed. The old instance ofgardener-node-agentwas using the new config. With this fix we add a suffix containing its version, which would helpgardener-node-agentuse the correct config file.Which issue(s) this PR fixes:
Fixes #11025
Special notes for your reviewer:
Release note: