Add in-place update filtering for machine images in maintenance controller #12577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ary1992
reviewed
Jul 21, 2025
pkg/controllermanager/controller/shoot/maintenance/reconciler.go
Outdated
Show resolved
Hide resolved
|
LGTM label has been added. Git tree hash: 7946400204f463a10b5eb20d63562a1af91e620d
|
shafeeqes
reviewed
Jul 21, 2025
pkg/controllermanager/controller/shoot/maintenance/reconciler.go
Outdated
Show resolved
Hide resolved
|
/lgtm |
|
LGTM label has been added. Git tree hash: e4976c910ab04fa9cc83fe420f7aa431ce3ec6f4
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: acumino The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 3889eae86fc5f8286c91c8b97bd2bf376ea93f2b
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality usability
/kind enhancement
What this PR does / why we need it:
Introduces filterForInPlaceUpdateConstraint to ensure only machine image versions supporting in-place updates are considered when the worker update strategy is set to AutoInPlaceUpdate/ManualnPlaceUpdate.
Which issue(s) this PR fixes:
Part of #10219
Special notes for your reviewer:
/cc @shafeeqes @ary1992
Release note: