[GEP-28] gardenadm discover
#12570
Merged
[GEP-28] gardenadm discover
#12570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/assign |
ScheererJ
reviewed
Jul 18, 2025
needed for audit policy in shoot spec (for example)
1c4b1a8 to
aa6320e
Compare
- path to shoot manifest file is the first (and only) argument - `-d, --config-dir` (optional) for providing a path to a directory where the configuration should be downloaded to. if not provided, the directory of the shoot manifest is used - `-k, --kubeconfig` (optional) for providing a kubeconfig to the garden cluster from where the configuration should be downloaded
- prevent spam in `gardenadm discover` - for the usage in `gardener-admission-controller`, we never really needed to look at these logs in the past 4-5 years, so I guess we are good moving them to debug level
aa6320e to
b6f3e01
Compare
|
LGTM label has been added. Git tree hash: 1a3e9687bec5bae5f0209075e1563d6510ff9cc9
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ScheererJ The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
* AutonomousBotanist also handles `ConfigMap`s needed for audit policy in shoot spec (for example) * Prepare options - path to shoot manifest file is the first (and only) argument - `-d, --config-dir` (optional) for providing a path to a directory where the configuration should be downloaded to. if not provided, the directory of the shoot manifest is used - `-k, --kubeconfig` (optional) for providing a kubeconfig to the garden cluster from where the configuration should be downloaded * Default kubeconfig path option * Prefactor: Move `graph` package to `pkg/utils` * VertexTypes can create a new `client.Object` * Export some types from the `graph` package * Move graph logs to `V(1)` - prevent spam in `gardenadm discover` - for the usage in `gardener-admission-controller`, we never really needed to look at these logs in the past 4-5 years, so I guess we are good moving them to debug level * Read shoot manifest and create client * `gardenadm discover` * Unit tests * Address PR review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area ipcei
/kind enhancement
What this PR does / why we need it:
This PR implements
gardenadm discover. The goal of this command is to connect to an existing Gardener system (ideally, the one where the to-be-created autonomous shoot cluster is registered with later), and download the required configuration files (CloudProfile,ControllerRegistration, etc.).It takes a path to a file containing a
Shootmanifest and uses thegraphpackage (currently only used bygardener-admission-controller's seed authorizer webhook) in order to determine the dependent resources.Those are then downloaded and exported into dedicated files. Missing resources are ignored.
Which issue(s) this PR fixes:
Part of #2906
Special notes for your reviewer:
/cc @ScheererJ @timebertt
PR is still in draft because unit tests are missing - submitted for early feedback :)
Release note: