Improve validations for worker related fields in the shoot spec #12567
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cd2593c to
8bed53d
Compare
|
/assign |
dddc4f2 to
f02373e
Compare
shafeeqes
reviewed
Jul 25, 2025
|
/retest |
7c2c5e6 to
e45840d
Compare
shafeeqes
reviewed
Aug 1, 2025
shafeeqes
reviewed
Aug 1, 2025
34d9cad to
8f2fa23
Compare
|
/lgtm |
|
/retest |
rfranzke
reviewed
Aug 5, 2025
| "Detail": Equal("must be non-negative"), | ||
| })))) | ||
| }) | ||
| It("should forbid setting MachineHealthTimeout to a negative value", func() { |
There was a problem hiding this comment.
Nit: newline between multiple Its
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shafeeqes
reviewed
Aug 6, 2025
|
/lgtm |
|
Sorry, it didn't work. |
8cd650a to
c3f80b4
Compare
|
/lgtm |
|
/retest |
1 similar comment
|
/retest |
acumino
requested changes
Aug 6, 2025
|
/lgtm |
|
LGTM label has been added. Git tree hash: f0539c155b19eca430b75e1882e01ada94f2ecbb
|
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
…ener#12567) * Improve validations for spec.provider.workers[] and spec.kubernetes.clusterAutoscaler * Addressed review feedback * Added test case for kubernetes.clusterAutoscaler.verbosity * Update validation for maxEvictRetries * Adjust validations for inPlace values of worker and add these fields to 90-shoot.yaml * nit: add newlines between Its * Update pkg/apis/core/validation/shoot_test.go * Fix unit tests --------- Co-authored-by: Shafeeque E S <shafeeque.e.s@sap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area quality
/area robustness
/area security
/kind enhancement
What this PR does / why we need it:
This PR improves input value validations for fields within the following
spec.provider.workers[]spec.kubernetes.clusterAutoscalerWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: