Promote Feature Gate `NewWorkerPoolHash` to `Beta` and default to `true` #12550

Duciwuci · 2025-07-17T07:38:46Z

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
This PR promotes the feature gate NewWorkerPoolHash to Beta status.
Now that we had the feature gate in alpha for 27 versions, we are confident this can go Beta.

Which issue(s) this PR fixes:
Fixes #9699

Special notes for your reviewer:

Release note:

⚠️ The `NewWorkerPoolHash` feature gate has been promoted to beta and is now enabled by default. When the feature gate is enabled, changes to `kubeReserved`, `systemReserved`, `evictionHard` or `cpuManagerPolicy` in the `kubelet` of the `Shoot` will trigger a node-roll. All provider extensions must be upgraded to a version which includes Gardener `v1.98.0` first to support this feature.

gardener-prow · 2025-07-17T07:38:55Z

Welcome @Duciwuci!

It looks like this is your first PR to gardener/gardener 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if gardener/gardener has its own contribution guidelines.

Thank you, and welcome to Gardener. 😃

gardener-prow · 2025-07-17T07:38:56Z

Hi @Duciwuci. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

rfranzke · 2025-07-17T12:57:05Z

/cc @voelzmo @adenitiu

gardener-prow · 2025-07-17T12:57:08Z

@rfranzke: GitHub didn't allow me to request PR reviews from the following users: adenitiu.

Note that only gardener members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @voelzmo @adenitiu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

docs/deployment/feature_gates.md

Signed-off-by: Duciwuci <duciwuci@gmail.com>

Duciwuci · 2025-07-18T08:12:46Z

Thanks @ialidzhikov ! I added your review to the last commit.

shafeeqes

Can we change the PR description to
"Part of #9699" and mark it is fixed when the feature gate is removed?

docs/deployment/feature_gates.md

Duciwuci · 2025-07-25T07:30:38Z

@shafeeqes I shifted the Docs to g/g 1.125

Duciwuci · 2025-07-25T08:01:47Z

I marked this as breaking as well.

shafeeqes · 2025-07-25T14:09:48Z

/lgtm

gardener-prow · 2025-07-25T14:09:54Z

LGTM label has been added.

Git tree hash: 009dca2fec159716c567df1969f1c6777884c538

Duciwuci · 2025-07-28T07:12:27Z

/retest

gardener-prow · 2025-07-28T07:12:43Z

@Duciwuci: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Duciwuci · 2025-07-28T07:13:14Z

@shafeeqes can leave me a ok-to-test?

ialidzhikov · 2025-07-29T11:14:49Z

/ok-to-test

Duciwuci · 2025-07-30T11:51:50Z

@shafeeqes @ialidzhikov good to go like this. Thank you both!

acumino · 2025-07-31T09:18:32Z

/assign

acumino

/lgtm

gardener-prow · 2025-07-31T09:33:33Z

LGTM label has been added.

Git tree hash: 177ad15addaae58aa537e97a8e582455acf31f09

ialidzhikov · 2025-07-31T09:41:19Z

I guess @voelzmo and @adenitiu are looking into this feature on our side. Let's wait for feedback for them as well.

adenitiu · 2025-08-07T05:48:58Z

/lgtm

gardener-prow · 2025-08-07T05:49:01Z

@adenitiu: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

docs/deployment/feature_gates.md

pkg/features/features.go

Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>

Duciwuci · 2025-08-07T08:13:00Z

@rfranzke thanks. Adjusted the Docs.

Duciwuci · 2025-08-07T08:16:09Z

/test pull-gardener-unit

rfranzke

/lgtm
/approve

gardener-prow · 2025-08-07T09:12:18Z

LGTM label has been added.

Git tree hash: 709e26203864b37d70ff619561b2ea663b1202ea

gardener-prow · 2025-08-07T09:12:19Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [rfranzke]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Duciwuci · 2025-08-07T09:14:50Z

/test pull gardener-e2e-kind-ha-multi-node

gardener-prow · 2025-08-07T09:15:07Z

@Duciwuci: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test pull-gardener-check-renovate-config

/test pull-gardener-e2e-kind

/test pull-gardener-e2e-kind-gardenadm

/test pull-gardener-e2e-kind-ha-multi-node

/test pull-gardener-e2e-kind-ha-multi-node-upgrade

/test pull-gardener-e2e-kind-ha-multi-zone

/test pull-gardener-e2e-kind-ha-multi-zone-upgrade

/test pull-gardener-e2e-kind-ipv6

/test pull-gardener-e2e-kind-migration

/test pull-gardener-e2e-kind-migration-ha-multi-node

/test pull-gardener-e2e-kind-operator

/test pull-gardener-e2e-kind-operator-seed

/test pull-gardener-e2e-kind-upgrade

/test pull-gardener-integration

/test pull-gardener-unit

/test pull-gardener-verify-image-build

The following commands are available to trigger optional jobs:

/test pull-gardener-apidiff

Use /test all to run the following jobs that were automatically triggered:

pull-gardener-apidiff

pull-gardener-e2e-kind

pull-gardener-e2e-kind-gardenadm

pull-gardener-e2e-kind-ha-multi-node

pull-gardener-e2e-kind-ha-multi-node-upgrade

pull-gardener-e2e-kind-ha-multi-zone

pull-gardener-e2e-kind-ha-multi-zone-upgrade

pull-gardener-e2e-kind-ipv6

pull-gardener-e2e-kind-migration

pull-gardener-e2e-kind-migration-ha-multi-node

pull-gardener-e2e-kind-operator

pull-gardener-e2e-kind-operator-seed

pull-gardener-e2e-kind-upgrade

pull-gardener-integration

pull-gardener-unit

pull-gardener-verify-image-build

In response to this:

/test pull gardener-e2e-kind-ha-multi-node

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Duciwuci · 2025-08-07T09:29:47Z

/test pull-gardener-e2e-kind-ha-multi-node

Duciwuci · 2025-08-07T11:05:52Z

/test pull-gardener-e2e-kind-ha-multi-node

…ue` (gardener#12550) * promote NewWorkerPoolHash to Beta and default to true * fill docs and remove feature gate for dev setup Signed-off-by: Duciwuci <duciwuci@gmail.com> * shift feature gate to 1.125 * fix unit tests * Update docs/deployment/feature_gates.md Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> * Update pkg/features/features.go Co-authored-by: Rafael Franzke <rafael.franzke@sap.com> --------- Signed-off-by: Duciwuci <duciwuci@gmail.com> Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>

promote NewWorkerPoolHash to Beta and default to true

ca23185

gardener-prow bot added area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels Jul 17, 2025

gardener-prow bot requested review from acumino and shafeeqes July 17, 2025 07:38

gardener-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 17, 2025

gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 17, 2025

gardener-prow bot requested a review from voelzmo July 17, 2025 12:57

ialidzhikov requested changes Jul 17, 2025

View reviewed changes

docs/deployment/feature_gates.md Outdated Show resolved Hide resolved

docs/deployment/feature_gates.md Outdated Show resolved Hide resolved

docs/deployment/feature_gates.md Outdated Show resolved Hide resolved

gardener-prow bot assigned ialidzhikov Jul 17, 2025

fill docs and remove feature gate for dev setup

479ce45

Signed-off-by: Duciwuci <duciwuci@gmail.com>

shafeeqes reviewed Jul 25, 2025

View reviewed changes

docs/deployment/feature_gates.md Outdated Show resolved Hide resolved

shift feature gate to 1.125

47c6d2d

gardener-prow bot assigned shafeeqes Jul 25, 2025

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2025

gardener-prow bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 29, 2025

gardener-prow bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 30, 2025

gardener-prow bot assigned acumino Jul 31, 2025

acumino reviewed Jul 31, 2025

View reviewed changes

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 31, 2025

rfranzke reviewed Aug 7, 2025

View reviewed changes

docs/deployment/feature_gates.md Outdated Show resolved Hide resolved

pkg/features/features.go Outdated Show resolved Hide resolved

Update docs/deployment/feature_gates.md

623d0b4

Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>

gardener-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025

gardener-prow bot requested a review from acumino August 7, 2025 08:12

Update pkg/features/features.go

ba564f8

Co-authored-by: Rafael Franzke <rafael.franzke@sap.com>

rfranzke reviewed Aug 7, 2025

View reviewed changes

gardener-prow bot assigned rfranzke Aug 7, 2025

gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 7, 2025

gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 7, 2025

gardener-prow bot merged commit 08c420c into gardener:master Aug 7, 2025
19 checks passed

Promote Feature Gate NewWorkerPoolHash to Beta and default to true #12550

Promote Feature Gate NewWorkerPoolHash to Beta and default to true #12550

Uh oh!

Conversation

Duciwuci commented Jul 17, 2025 • edited by ialidzhikov Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gardener-prow bot commented Jul 17, 2025

Uh oh!

gardener-prow bot commented Jul 17, 2025

Uh oh!

rfranzke commented Jul 17, 2025

Uh oh!

gardener-prow bot commented Jul 17, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Duciwuci commented Jul 18, 2025

Uh oh!

shafeeqes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Duciwuci commented Jul 25, 2025

Uh oh!

Duciwuci commented Jul 25, 2025

Uh oh!

shafeeqes commented Jul 25, 2025

Uh oh!

gardener-prow bot commented Jul 25, 2025

Uh oh!

Duciwuci commented Jul 28, 2025

Uh oh!

gardener-prow bot commented Jul 28, 2025

Uh oh!

Duciwuci commented Jul 28, 2025

Uh oh!

ialidzhikov commented Jul 29, 2025

Uh oh!

Duciwuci commented Jul 30, 2025

Uh oh!

acumino commented Jul 31, 2025

Uh oh!

acumino left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Jul 31, 2025

Uh oh!

ialidzhikov commented Jul 31, 2025

Uh oh!

adenitiu commented Aug 7, 2025

Uh oh!

gardener-prow bot commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Duciwuci commented Aug 7, 2025

Uh oh!

Duciwuci commented Aug 7, 2025

Uh oh!

rfranzke left a comment

Choose a reason for hiding this comment

Uh oh!

gardener-prow bot commented Aug 7, 2025

Uh oh!

gardener-prow bot commented Aug 7, 2025

Uh oh!

Duciwuci commented Aug 7, 2025

Uh oh!

gardener-prow bot commented Aug 7, 2025

Uh oh!

Duciwuci commented Aug 7, 2025

Uh oh!

Duciwuci commented Aug 7, 2025

Uh oh!

Uh oh!

Uh oh!

Promote Feature Gate `NewWorkerPoolHash` to `Beta` and default to `true` #12550

Promote Feature Gate `NewWorkerPoolHash` to `Beta` and default to `true` #12550

Duciwuci commented Jul 17, 2025 •

edited by ialidzhikov

Loading