[GEP-33] Add Capabilities support to Worker MachineImage Version defaulting #12529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c95d063 to
1ed9590
Compare
26 tasks
cf2daae to
81da807
Compare
31a3596 to
c2f0a12
Compare
pkg/controllermanager/controller/shoot/maintenance/reconciler_test.go
Outdated
Show resolved
Hide resolved
c2f0a12 to
771d238
Compare
|
/lgtm |
|
LGTM label has been added. Git tree hash: 40221c6f82b3facd9560a8a21070a3f45ffe7d28
|
|
/retest-required |
1 similar comment
|
/retest-required |
timuthy
reviewed
Aug 5, 2025
pkg/controllermanager/controller/shoot/maintenance/helper/helper.go
Outdated
Show resolved
Hide resolved
|
LGTM label has been added. Git tree hash: fa636aa1e3faa2eb096c4d2b74d1f4906d90800d
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: timuthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Duciwuci
pushed a commit
to stackitcloud/gardener
that referenced
this pull request
Sep 1, 2025
…ulting (gardener#12529) * Enhance worker machine image defaulting with capabilities support * Implement capabilities filtering for machine images in shoot maintenance controller * move capability filter logic to helper package and cleanup nits * improve readability and update docstrings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/kind enhancement
/area usability
/area os
What this PR does / why we need it:
Implementation as part of GEP-33.
Adds capability filter in the shoot maintenance controller for machine image versions.
Adds capability support to worker image version defaulting during shoot admission.
This functionality is part of
getDefaultMachineImage. The check is performed only if the worker specifies a valid machineType. If the machineType is not found in the CloudProfile, the check is skipped. We avoid failing early to ensure that the error message at L1172 still provides users with recommendations for supported machineTypes.Which issue(s) this PR fixes:
Part of #11301
Special notes for your reviewer:
@LucaBernstein @timuthy
Release note: